Also, as you can see in this screenshot, a part of the editor took the footer's color.

@Nirzar @ovasileva This should actually be a subtask of pushing the footer change to stable.

Adding space at bottom of page so that the footer can be scrolled past (diff toolbar sits above it)

This should be the fix for this issue. If we have sticky elements,
height of sticky element = extra bottom padding

The recently added mock by @Jdlrobson looks good.

#mw-mf-userinfo has min-height: 5em; and 1em padding
It's not a border-box element.

It seems we use min-height as the user groups can spill onto a second group (e.g. https://en.m.wikipedia.org/wiki/Special:MobileDiff/741615580)

I think the best solution is probably to add a class to the body element whenever a fixed footer is being used e.g. feature-fixed-footer.

When this is present:

• Restrict #mw-mf-userinfo to 6em height
• add a margin-bottom: 8em; to footer
• Remove bottom margin on mw-mf-diffarea

This means on certain pages, the footer information may get cut off. I'm not sure how important that is however:

(I'm not planning on working on this today but if the above sounds sane go for it!)

Any thoughts @bmansurov @phuedx @jhobs @Jhernandez ?

The approach in T144579#2675497 seems fine to me. Alternatively, we could add the styles directly for each page that is affected by it, but I think the tradeoff of a few extra bytes for a new class is worth following DRY principles (and future-proofing it).

fyi @ovasileva @Jhernandez @bmansurov if we don't ship this today this is going to push back release of related articles by a week.

I see the space is already reserved after the diff content. I suggest we make the sticky element stick to the bottom of the content and not to the bottom of the page. @Nirzar, would you be OK if we implemented this suggestion? Otherwise, it is confusing that the footer comes before this sticky element with the proposed solution.

@Jdlrobson - I think it's best to remove this as a blocker to pushing the footer to stable - we can go back and fix it later

talked to @bmansurov i think we should go ahead with margin fix that is proposed here. this is a blocker for new footer and footer is blocker for related pages. we can come back to improving diff pages later. for now. the proposed solution should work.

Position fixed is always positioning an element relative to the window. You can position it absolutely to the bottom of the page but it will not stay there when scrolled. Can you clarify what you mean @bmansurov ?

Never mind, let's go with the original solution. I was thinking of adding absolute positioning the the element in question and adding the element itself after the content but before the footer. It may not work. ;)

Change 313895 had a related patch set uploaded (by Jdlrobson):
Should be possible to scroll to footer on diff page

https://gerrit.wikimedia.org/r/313895

Change 313895 merged by jenkins-bot:
Should be possible to scroll to footer on diff page

https://gerrit.wikimedia.org/r/313895

@bmansurov @Jdlrobson Needs device/browser information for the QA plan, all of https://www.mediawiki.org/wiki/Reading/Web/QA_device_and_browsers_list? Just one?

I tested this on multiple browsers but came across an issue on iOS 9 Safari (iPhone 6 iOS 9.3.2) as seen in the screencap below the page footer bounces right back under the user information when I scrolled to it.

@jhobs, I can reproduce it 100% of the time. Just make sure the iOS version is 9.3 (I haven't tried others) and visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/265240?mobileaction=beta. Then scroll to the bottom of the page. That's it.

@bmansurov can you try looking at it then? I just tried again and it's not happening for me in iOS Simulator, version 9.3 selected.

@jhobs, here is what I have. I'm just curios why this is not happening on your end.

I'll upload the patch as soon as gerrit is up again.

Change 314747 had a related patch set uploaded (by Bmansurov):
Get rid of footer margin collapsing on Special:MobileDiff

https://gerrit.wikimedia.org/r/314747

Change 314747 merged by jenkins-bot:
Get rid of footer margin collapsing on Special:MobileDiff

https://gerrit.wikimedia.org/r/314747

In T144579#2699879, @bmansurov wrote:

@jhobs, here is what I have. I'm just curios why this is not happening on your end.

@bmansurov Just following up on this: it turns out my version of iOS Simulator was out of date, which was somehow causing this to not be reproducible (although I'm baffled as to why). I updated it to the latest and was able to reproduce it on 9.3. Thanks for fixing it up while I sorted out those issues Baha.

Testing again on iOS 9 Safari (iPhone 6 iOS 9.3.2), this time i followed the link @jhobs said above and now this is fixed.