Page MenuHomePhabricator

Kartographer maps are not shown in Wikipedia App
Closed, DuplicatePublic

Description

kartographer maps aren't shown in Wikipedia App (Android and iOS):
For example https://he.wikipedia.org/wiki/%D7%97%D7%95%D7%A8%D7%91%D7%AA_%D7%9B%D7%A0%D7%A3

It doesn't even degrade gracefully - e.g there is a large white space block due to the map.

Event Timeline

Moving the discussion from the other ticket to this one:

@JMinor Maps on iOS seems to be limited to the Nearby feature so far. Given this I get how it can be much simpler to implement with Apple libraries.

However, Maps (Kartographer) has been deployed to several wikis already, and aims at more wikis (once all the considerations will be resolved). The extension allows editors to embed rich maps with complex GeoJSON overlays in wikipedia articles. The number of articles with maps is still relatively low but it's growing. As part of this decision to use Apple maps, have you considered any mid/long-term plan to support articles' interactive maps in the native app? Have you decided to reduce the feature to the static snapshot image in the iOS app?

@JGirault please subscribe/comment on this ticket which tracks in article Kartographer support. T143877

I tried to raise several incompatibility issue with apps and maps last year but was told it was not a priority for the maps team.

  • What's the iOS/Android teams plan regarding Kartographer maps?
  • What's needed from the Kartographer developers to enable you?
  • What's the iOS/Android teams plan regarding Kartographer maps?
  • What's needed from the Kartographer developers to enable you?

I guess the apps have 2 options:

  1. Display the static snapshot only, no interactivity with the map (on click, display the static image in full screen maybe?)
  2. Support Kartographer's GeoJSON overlays on top of an interactive map

Option 1 should not be too hard, option 2 requires more work, investigation and estimation (Apple Maps vs Mapbox, + support of Kartographer's extension of GeoJSON, + display of links to external services, + ... TBD).

I don't recall details, but at the time I'm not sure 1 was an option yet.

For 2, yes, it may actually be quite complicated. I think a major blocker for us was that (and forgive if I'm wrong) the map tags and geojson overlays allowed/required the use of absolute pixel offsets. This was a non-starter for scalable mobile support.

@JMinor regarding 2. While it does not have full interactivity atm when embedded (at narrow screensizes), it does allow you to fullscreen, and give you interactivity from the fullscreen view. See https://en.m.wikivoyage.org/wiki/%27s-Hertogenbosch#Get_around Don't see why it wouldn't work for apps.

For 2, yes, it may actually be quite complicated. I think a major blocker for us was that (and forgive if I'm wrong) the map tags and geojson overlays allowed/required the use of absolute pixel offsets. This was a non-starter for scalable mobile support.

As most maps give a combination of center [latitude, longitude] and zoom, the map would take the container size and given the {zoom,center}, it should display it correctly.

However, these tags are optional, as one Kartographer feature is to auto-position the map to dynamically fit all GeoJSON features on the map. A similar implementation, or a service API, would have to be made I guess. This is already implemented in JavaScript by Kartographer and Kartotherian.

MSantos raised the priority of this task from Medium to Needs Triage.Nov 1 2018, 3:08 PM
Mholloway moved this task from Unsorted to General on the Maps (Kartographer) board.