Page MenuHomePhabricator
Create Task
Maniphest T141862

Visual seperation of qualifiers, references
Closed, ResolvedPublic
Actions

Assigned To
• Jonas
Authored By
• Jan_Dittrich
Aug 2 2016, 10:46 AM
Tags
Referenced Files
F4360095: pasted_file
Aug 13 2016, 7:22 PM
F4360093: pasted_file
Aug 13 2016, 7:22 PM
F4344917: pasted_file
Aug 8 2016, 10:50 AM
F4328987: Screenshot_20160707_162656.png
Aug 2 2016, 10:46 AM
Subscribers
Aklapper
Charlie_WMDE
gerritbot
• Jan_Dittrich
• Jonas
Lydia_Pintscher
thiemowmde

Description

User Story: As a user I want to recognize easily which properties belong to one reference/qualifier and which to another.

Suggestion: CSS change like below:

Screenshot_20160707_162656.png (743×828 px, 44 KB)

Details

SubjectRepoBranchLines +/-
Remove bogus CSS selectors when statementview shows an errormediawiki/extensions/Wikibasemaster+1 -3
Full background for property labels on new statementsmediawiki/extensions/Wikibasemaster+1 -3
Visual seperation of qualifiers, referencesmediawiki/extensions/Wikibasemaster+2 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Jan_Dittrich created this task.Aug 2 2016, 10:46 AM
Restricted Application added a project: Design. · View Herald TranscriptAug 2 2016, 10:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Jan_Dittrich added a project: Wikidata-Sprint-2016-08-02.Aug 2 2016, 10:47 AM
thiemowmde moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-08-02 board.Aug 2 2016, 1:03 PM
Lydia_Pintscher removed Lydia_Pintscher as the assignee of this task.Aug 2 2016, 1:47 PM
Lydia_Pintscher added a parent task: T137781: Adding/Editing references is confusing.
Lydia_Pintscher subscribed.
• Jonas claimed this task.Aug 8 2016, 10:46 AM
• Jonas moved this task from Backlog to Doing on the Wikidata-Sprint-2016-08-02 board.
• Jonas added a comment.Aug 8 2016, 10:50 AM

Is this the intended way it should look like with qualifiers?

pasted_file (653×1 px, 58 KB)

gerritbot subscribed.Aug 9 2016, 8:25 AM

Change 303769 had a related patch set uploaded (by Jonas Kress (WMDE)):
Visual seperation of qualifiers, references

https://gerrit.wikimedia.org/r/303769

• Jonas added a project: Patch-For-Review.Aug 9 2016, 8:26 AM
• Jonas moved this task from Doing to Review on the Wikidata-Sprint-2016-08-02 board.Aug 9 2016, 8:43 AM
• Jonas closed this task as Resolved.Aug 9 2016, 11:46 AM
• Jonas moved this task from Review to Done on the Wikidata-Sprint-2016-08-02 board.
gerritbot added a comment.Aug 9 2016, 11:57 AM

Change 303769 merged by jenkins-bot:
Visual seperation of qualifiers, references

https://gerrit.wikimedia.org/r/303769

Charlie_WMDE added a comment.Aug 10 2016, 10:09 AM

@Jonas yes. But now that I see it I'm not very happy with the way the values/qualifiers look. I'll talk to @Jan_Dittrich and @Lydia_Pintscher about this again.

• Jonas moved this task from Done to Doing on the Wikidata-Sprint-2016-08-02 board.Aug 13 2016, 7:20 PM

When adding new statement it looks broken :(

pasted_file (444×991 px, 29 KB)

pasted_file (204×943 px, 12 KB)

• Jonas reopened this task as Open.Aug 13 2016, 7:22 PM
• Jan_Dittrich added a comment.Aug 15 2016, 6:41 AM

oha. I try to find a solution; also we may just sit together and co-design/program this, it's probably fastest.

thiemowmde added a comment.Aug 15 2016, 10:03 AM

@Jonas, @Jan_Dittrich, as far as I can tell this is not new. We removed the bright blue background color. Everything else is as before, including the weird highlighting of the property. I suggest to open a separate task for this.

• Jonas added a comment.Aug 15 2016, 10:36 AM

You are right this behavior is old, but now it looks even worse I think.

gerritbot added a comment.Aug 15 2016, 4:15 PM

Change 304846 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Full background for property labels on new statements

https://gerrit.wikimedia.org/r/304846

• Jonas closed this task as Resolved.Aug 15 2016, 7:46 PM
• Jonas moved this task from Doing to Done on the Wikidata-Sprint-2016-08-02 board.
gerritbot added a comment.Aug 15 2016, 7:54 PM

Change 304846 merged by jenkins-bot:
Full background for property labels on new statements

https://gerrit.wikimedia.org/r/304846

gerritbot added a comment.Aug 16 2016, 8:21 AM

Change 304987 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove bogus CSS selectors when statementview shows an error

https://gerrit.wikimedia.org/r/304987

gerritbot added a comment.Aug 29 2016, 3:15 PM

Change 304987 merged by jenkins-bot:
Remove bogus CSS selectors when statementview shows an error

https://gerrit.wikimedia.org/r/304987

Charlie_WMDE moved this task from Incoming to Done on the WMDE-Design board.Nov 8 2016, 4:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits