wikistats xml sometimes contains str instead of unicode on Python 2
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jayvdb
	Mar 8 2016, 7:29 PM

Description

Split off from T128990: English Wikisource has more good pages than French Wikisource, breaking the WikiStats tests for the largest wikisource, wikistats_tests test_xml is failing with the xml data values containing str on Python 2 instead of unicode, which makes it slightly incompatible with the default csv implementation.

Originally identified by @Xqt and solution proposed as https://gerrit.wikimedia.org/r/269730

Additional asserts where added in 0170860dd to confirm the problem.

The problem has not been reproducible on Travis Unix or Appveyor Windows CI builds.

	Subject	Repo	Branch	Lines +/-
	[bugfix] force wikistats fields to unicode when using xml format	pywikibot/core	master	+3 -2

rPWBC pywikibot
	rPWBC0170860dd518 Expand wikistats datatype tests

Status	Assigned	Task
Resolved	Xover	T265640 phe-tools: Match&Split bot is not running because of python2 deprecation in pywikibot
Resolved	Xqt	T213287 Drop support of Python 2.7
Resolved	Xqt	T243770 Pywikibot Python 2 compatibility (tracking)
Resolved	jayvdb	T129268 wikistats xml sometimes contains str instead of unicode on Python 2

Change 275780 had a related patch set uploaded (by John Vandenberg):
[bugfix] force wikistats fields to unicode when using xml format

Change 275780 merged by jenkins-bot:
[bugfix] force wikistats fields to unicode when using xml format

To reproduce this bug now, revert d65a6e1c841 and run pwb.py tests/wikistats_tests -v using Python 2

Xqt closed this task as Resolved.Jan 30 2020, 1:57 PM

Xqt claimed this task.

Xqt reassigned this task from Xqt to jayvdb.