In the cancel event handler, the ULS window will be closed if any element other than the ULS trigger is clicked, even if that element is a descendant of the ULS trigger. This is a problem when the ULS trigger is an OOjs UI button.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Victorbarbu | T87244 Use ULS for language selection | |||
| Resolved | Victorbarbu | T122722 The cancel event handler closes the ULS even if a descendant of the trigger is clicked |
Event Timeline
Comment Actions
Change 261810 had a related patch set uploaded (by Victorbarbu):
Fix the cancel event function to prevent erroneous close
Comment Actions
Change 261810 merged by jenkins-bot:
Fix the cancel event function to prevent erroneous close
Comment Actions
Ahem @TTO, thanks for looking into this but this should not have been merged in gerrit first. This is an upstream library, the patch needs to be in https://github.com/wikimedia/jquery.uls too.