Minerva and desktop skins use inconsistent HTML
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Oct 9 2015, 8:49 PM

Description

The Vector skin wraps all user generated content in an element with id #mw-content-text
Let's also do this in Minerva so the two skins are more in line with each other.

This is a potential breaking change for those JavaScript modules who are not using the Page or Skin JavaScript classes so consider those and backwards compatibility when merging.

As we move forward and start to work on features that work on both desktop and mobile and do more in JS we want to minimise these inconsistencies.

When doing this, we should be sure to ensure that we do not break T113651

Details

	Subject	Repo	Branch	Lines +/-
	Breaking change: Move logic for section wrapping out of skin into hook	mediawiki/extensions/MobileFrontend	master	+28 -32

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
Resolved	Jdlrobson	T71366 [EPIC] Extract Minerva skin from MobileFrontend to its own repository
Resolved	Jdlrobson	T115147 Minerva and desktop skins use inconsistent HTML

Event Timeline

Jdlrobson created this task.Oct 9 2015, 8:49 PM

Jdlrobson raised the priority of this task from to Medium.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added projects: reading-web-sprint-58-The-Sixth-Sense, MobileFrontend.

Jdlrobson moved this task to Code Review on the reading-web-sprint-58-The-Sixth-Sense board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2015, 8:49 PM

Jdlrobson updated the task description. (Show Details)Oct 9 2015, 8:50 PM

Jdlrobson set Security to None.

Jdlrobson updated the task description. (Show Details)

Change 243227 had a related patch set uploaded (by Jdlrobson):
Hygiene: Move logic for section wrapping out of skin into hook

https://gerrit.wikimedia.org/r/243227

gerritbot added a project: Patch-For-Review.Oct 9 2015, 9:04 PM

Jdlrobson moved this task from Code Review to Needs Analysis on the reading-web-sprint-58-The-Sixth-Sense board.Oct 15 2015, 4:01 PM

Jdlrobson removed a project: reading-web-sprint-58-The-Sixth-Sense.Oct 28 2015, 9:25 PM

Guess we should probably talk about this. @bmansurov, @phuedx @jhobs - do we agree we should make the html of minerva more closely aligned to Vector?

In T115147#1766699, @Jdlrobson wrote:

Guess we should probably talk about this. @bmansurov, @phuedx @jhobs - do we agree we should make the html of minerva more closely aligned to Vector?

I'm definitely down for that. The fewer differences in HTML the better imo.

Yes, I agree.

Agreed. If we felt strongly enough that $wikitext should be rendered in a certain way, then we should discuss it with the wider community and upstream the changes. Otherwise, we should aim for parity.

Okay so the impact of this is we are making a breaking change. The only thing I'm aware of this breaking is QuickSurveys so we should make this change ASAP given we want to run a survey next week... or delay this until at least the first survey has been run.

Jdlrobson moved this task from Backlog to Team:Growth on the MobileFrontend board.Nov 4 2015, 4:47 PM

Jdlrobson added a parent task: T71366: [EPIC] Extract Minerva skin from MobileFrontend to its own repository.Dec 17 2015, 11:03 PM

Change 243227 merged by jenkins-bot:
Breaking change: Move logic for section wrapping out of skin into hook

https://gerrit.wikimedia.org/r/243227

Jdlrobson closed this task as Resolved.Dec 28 2015, 5:07 PM

Jdlrobson claimed this task.

Jdlrobson mentioned this in T122516: QuickSurveys get placed incorrectly in mobile skin.

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Dec 28 2015, 6:00 PM

• Konfused-Kitten mentioned this in rEQSfcaf98c06fca: Reflect Minerva breaking skin change.Apr 28 2016, 6:22 AM

• Konfused-Kitten mentioned this in rEQSd9826c0d7e75: Reflect Minerva breaking skin change.