Special:GlobalAllocation throws a php fatal "Undefined index: function "
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Glaisher
	Oct 9 2015, 11:26 AM

Description

https://meta.wikimedia.org/wiki/Special:GlobalAllocation

Details

	Subject	Repo	Branch	Lines +/-
	Handle $frame['function'] not being set in stack frames	mediawiki/core	master	+7 -2

Customize query in gerrit

Revisions and Commits

rMW MediaWiki
	rMW9144554931ae Handle $frame['function'] not being set in stack frames

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T124132 [Epic] Analytics, graphs and monitoring for banners and CentralNotice
		Resolved		Krinkle	T115107 Special:GlobalAllocation throws a php fatal "Undefined index: function "

Event Timeline

Glaisher created this task.Oct 9 2015, 11:26 AM

Glaisher raised the priority of this task from to Needs Triage.

Glaisher updated the task description. (Show Details)

Glaisher added projects: Wikimedia-production-error, MediaWiki-extensions-CentralNotice.

Glaisher subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2015, 11:26 AM

Luke081515 awarded a token.Oct 9 2015, 1:54 PM

Luke081515 subscribed.

2015-10-09 14:52:14 mw1091 metawiki fatal ERROR: [74b544e5] PHP Fatal Error: request has exceeded memory limit {"exception_id":"74b544e5"} 
[Exception ErrorException] (/srv/mediawiki/php-1.27.0-wmf.2/extensions/CentralNotice/special/SpecialGlobalAllocation.php:435) PHP Fatal Error: request has exceeded memory limit
  #0 /srv/mediawiki/php-1.27.0-wmf.2/extensions/CentralNotice/special/SpecialGlobalAllocation.php(435): ()
  #1 /srv/mediawiki/php-1.27.0-wmf.2/extensions/CentralNotice/special/SpecialGlobalAllocation.php(432): SpecialGlobalAllocation::makeCombinations(array, integer)
  #2 /srv/mediawiki/php-1.27.0-wmf.2/extensions/CentralNotice/special/SpecialGlobalAllocation.php(432): SpecialGlobalAllocation::makeCombinations(array, integer)
  #3 /srv/mediawiki/php-1.27.0-wmf.2/extensions/CentralNotice/special/SpecialGlobalAllocation.php(432): SpecialGlobalAllocation::makeCombinations(array, integer)
  #4 /srv/mediawiki/php-1.27.0-wmf.2/extensions/CentralNotice/special/SpecialGlobalAllocation.php(344): SpecialGlobalAllocation::makeCombinations(array, integer)
  #5 /srv/mediawiki/php-1.27.0-wmf.2/extensions/CentralNotice/special/SpecialGlobalAllocation.php(265): SpecialGlobalAllocation->analyzeGroupings()
  #6 /srv/mediawiki/php-1.27.0-wmf.2/extensions/CentralNotice/special/SpecialGlobalAllocation.php(215): SpecialGlobalAllocation->showList()
  #7 /srv/mediawiki/php-1.27.0-wmf.2/includes/specialpage/SpecialPage.php(384): SpecialGlobalAllocation->execute(NULL)
  #8 /srv/mediawiki/php-1.27.0-wmf.2/includes/specialpage/SpecialPageFactory.php(553): SpecialPage->run(NULL)
  #9 /srv/mediawiki/php-1.27.0-wmf.2/includes/MediaWiki.php(249): SpecialPageFactory::executePath(Title, RequestContext)
  #10 /srv/mediawiki/php-1.27.0-wmf.2/includes/MediaWiki.php(662): MediaWiki->performRequest()
  #11 /srv/mediawiki/php-1.27.0-wmf.2/includes/MediaWiki.php(475): MediaWiki->main()
  #12 /srv/mediawiki/php-1.27.0-wmf.2/index.php(41): MediaWiki->run()
  #13 /srv/mediawiki/w/index.php(3): include(string)
  #14 {main}

@Krenair Is that related to this error? I don't see "Undefined index" there. (There's another old report about OOMs on this page as well).

In T115107#1715550, @Glaisher wrote:

@Krenair Is that related to this error? I don't see "Undefined index" there. (There's another old report about OOMs on this page as well).

I know it's weird, but this is the error that comes up in fatal.log when I browse to the page... The page shows "Undefined index: function".

Ah, and this in hhvm.log: Oct 9 14:52:14 mw1091: #012Notice: Undefined index: function in /srv/mediawiki/php-1.27.0-wmf.2/includes/exception/MWExceptionHandler.php on line 386

Can you link to the OOM report?

Why is it fatalling for undefined index? Shouldn't it be a php notice? :/

In T115107#1715605, @Krenair wrote:

Can you link to the OOM report?

{T55443}

In T115107#1715604, @Krenair wrote:

Ah, and this in hhvm.log: Oct 9 14:52:14 mw1091: #012Notice: Undefined index: function in /srv/mediawiki/php-1.27.0-wmf.2/includes/exception/MWExceptionHandler.php on line 386

So it's not actually a fatal.. Why does the error page say it's a fatal..?

Change 244712 had a related patch set uploaded (by Alex Monk):
Handle $frame['function'] not being set in stack frames

https://gerrit.wikimedia.org/r/244712

gerritbot added a project: Patch-For-Review.Oct 9 2015, 5:00 PM

In T115107#1715607, @Glaisher wrote:

Why is it fatalling for undefined index? Shouldn't it be a php notice? :/

The code handling the error page (hhvm-fatal-error.php in operations/mediawiki-config) looks for the last error and displays that. But in this case, we have two errors: the fatal, and then the notice which comes up in the exception handling code for the fatal. So it selects the notice, even though we actually want it to show the fatal.

Change 244712 merged by jenkins-bot:
Handle $frame['function'] not being set in stack frames

https://gerrit.wikimedia.org/r/244712

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)).Oct 14 2015, 2:00 PM

• mmodell added a commit: rMW9144554931ae: Handle $frame['function'] not being set in stack frames.Oct 22 2015, 8:14 PM

• demon triaged this task as Medium priority.Nov 3 2015, 10:51 PM

• demon set Security to None.

• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.

Krinkle closed this task as Resolved.Dec 11 2015, 2:37 AM

Krinkle claimed this task.

• demon moved this task from Dec2019/1.35.wmf.10+ to Resolved on the Wikimedia-production-error board.Dec 11 2015, 4:52 PM

AndyRussG added a parent task: T124132: [Epic] Analytics, graphs and monitoring for banners and CentralNotice.Jan 21 2016, 4:03 AM