Page MenuHomePhabricator
Create Task
Maniphest T110728

[Bug] Quantity field has bad data (\n)
Closed, ResolvedPublic
Actions

Description

Somehow on certain entities quantity field happens to have bad data, e.g. see:

https://www.wikidata.org/wiki/Special:EntityData/Q1427761.ttl?flavor=dump

The quantity field on P1083 is "+16100\n" which is obviously wrong. Same in JSON:

https://www.wikidata.org/wiki/Special:EntityData/Q1427761.json

There's quantity field:

"snaktype": "value",
"property": "P1083",
"datavalue": {
"value": {
"amount": "+16100\n",
"unit": "1",
"upperBound": "+16100\n",
"lowerBound": "+16100\n"
},
"type": "quantity"

This is obviously not correct and API should catch this and fix the data.

Related Objects
Search...

Event Timeline

Smalyshev created this task.Aug 28 2015, 7:47 PM
Smalyshev raised the priority of this task from to Needs Triage.
Smalyshev updated the task description. (Show Details)
Smalyshev added a project: Wikidata.
Smalyshev subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 28 2015, 7:47 PM
Lydia_Pintscher renamed this task from Quantity field has bad data (\n) to [Bug] Quantity field has bad data (\n).Aug 31 2015, 9:33 AM
Lydia_Pintscher triaged this task as High priority.
Lydia_Pintscher added a project: MediaWiki-extensions-WikibaseRepository.
Lydia_Pintscher set Security to None.
Lydia_Pintscher added a subscriber: daniel.
Lydia_Pintscher moved this task from incoming to needs discussion or investigation on the Wikidata board.Aug 31 2015, 10:03 AM
thiemowmde added a parent task: T56318: Quantity datatype (tracking).Sep 2 2015, 9:17 AM
Smalyshev added a comment.Sep 2 2015, 3:49 PM

Also, editing P1083 on Q1427761 seems to be broken too - edit field just does not appear.

thiemowmde claimed this task.EditedApr 21 2016, 11:57 AM
thiemowmde added projects: DataValues, Patch-For-Review, Wikidata-Sprint-2016-04-12.
thiemowmde subscribed.

Patches for review:

For your information, the reason is a bogus edge case in PCRE, see http://www.regular-expressions.info/anchors.html#realend. This edge case does not exist in ECMA/JavaScript.

daniel added a comment.Apr 21 2016, 1:26 PM

@thiemowmde thanks for digging this up. What the fuck, PCRE?! I bet this causes security holes in thousands of web apps. Maybe worth mentioning at Perl Jam 3... https://media.ccc.de/v/32c3-7130-the_perl_jam_2

thiemowmde added a parent task: T133299: [Task] Replace bogus $ anchor in regular expressions with \z.Apr 21 2016, 3:50 PM
Smalyshev added a comment.Apr 21 2016, 6:38 PM

Wow this is messed up. You could use D modifier though:

https://3v4l.org/33Gks
http://php.net/manual/en/reference.pcre.pattern.modifiers.php

D (PCRE_DOLLAR_ENDONLY)
If this modifier is set, a dollar metacharacter in the pattern matches only at the end of the subject string. Without this modifier, a dollar also matches immediately before the final character if it is a newline (but not before any other newlines). This modifier is ignored if m modifier is set. There is no equivalent to this modifier in Perl.

Existance of this modifier shows somebody already encountered this WTF :)

thiemowmde added a comment.EditedApr 23 2016, 5:57 PM

Patches for review:

thiemowmde moved this task from Proposed to Review on the Wikidata-Sprint-2016-04-12 board.Apr 23 2016, 5:57 PM
• adrianheine closed this task as Resolved.Apr 26 2016, 9:44 AM
• adrianheine moved this task from Review to Done on the Wikidata-Sprint-2016-04-12 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits