https://integration.wikimedia.org/ci/job/mediawiki-phpunit-hhvm/13036/console
23:41:24 1) ResourceLoaderModuleTest::testGetVersionHash 23:41:24 Instance is insignificant 23:41:24 Failed asserting that two strings are equal. 23:41:24 --- Expected 23:41:24 +++ Actual 23:41:24 @@ @@ 23:41:24 -'"LbL7EHCM"' 23:41:24 +'"Dm06PwWa"' 23:41:24
I've seen similar failures multiple times today already.
When removing the makeHash() call from ResourceLoaderModule::getVersionHash one can get a hold of the underlying difference:
'"{\"_class\":\"ResourceLoaderFileModule\",\"_cacheEpoch\":\"20140101000000\",\"0\":{
\"options\":{\"scripts\":[\"foo.js\",\"bar.js\"],\"debugScripts\":[],\"loaderScripts\":[],\"styles\":[],\"languageScripts\":[],\"skinScripts\":[],\"skinStyles\":[],\"messages\":[\"hello\",\"world\"],\"templates\":[],\"skipFunction\":null,\"debugRaw\":true,\"raw\":false},
\"fileHashes\":[\"\",\"\"],
- \"msgBlobMtime\":\"1442350245\"}}"'
'"{\"_class\":\"ResourceLoaderFileModule\",\"_cacheEpoch\":\"20140101000000\",\"0\":{
\"options\":{\"scripts\":[\"foo.js\",\"bar.js\"],\"debugScripts\":[],\"loaderScripts\":[],\"styles\":[],\"languageScripts\":[],\"skinScripts\":[],\"skinStyles\":[],\"messages\":[\"hello\",\"world\"],\"templates\":[],\"skipFunction\":null,\"debugRaw\":true,\"raw\":false},
\"fileHashes\":[\"\",\"\"],
+ \"msgBlobMtime\":\"1442350246\"}}"'This isn't new and was also previously happening with testDefinitionSummary for getModifiedTime. It's due to lack of in-process caching and the clock ticking during the test execution. It happens about 1 every 50 runs when I reproduce it locally (by running php phpunit.php includes/resourceloader/ResourceLoaderModuleTest.php many times in a row).
See also:
It happens about 1 every 50 runs
Maybe I just have bad luck, but I keep running into it when merging patches. What's the plan to fix this? We (well, you really) would have disabled any other flaky test like this long ago.
It'll be fixed very soon. Both @Krinkle and I are looking at how module versioning works.
Change 247503 had a related patch set uploaded (by Krinkle):
resourceloader: Disable flaky test ResourceLoaderModule::getVersionHash
Change 247503 merged by jenkins-bot:
resourceloader: Disable flaky test ResourceLoaderModule::getVersionHash
Change 258021 had a related patch set uploaded (by Krinkle):
resourceloader: Re-enable getVersionHash test