Page MenuHomePhabricator

Update broken gadgets on WMF wikis (tracking)
Closed, InvalidPublic

Description

Three of the gadgets on English Wikipedia are currently broken because they haven't been updated to use ResourceLoader.

  • ImageAnnotator
  • HideCentralNotice and
  • The JavaScript Standard Library

It would be nice to fix them :) Similarly for other WMF wikis.

Related Objects

StatusSubtypeAssignedTask
InvalidNone
DeclinedAklapper
ResolvedJdforrester-WMF
ResolvedMjbmr
Resolvedkaldari
DuplicateNone
DeclinedArkanosis
Resolvedkaldari
ResolvedNone
ResolvedNone
ResolvedNone
Resolvedkaldari
Resolvedkaldari
Resolvedkaldari
Resolvedkaldari
Resolvedkaldari
Resolvedkaldari
Resolvedkaldari
ResolvedNiharika
ResolvedNiharika
ResolvedNone
Resolvedkaldari
DeclinedNone
ResolvedKrinkle
Resolved Catrope
Resolved matmarex
InvalidNone
InvalidIneuw
DeclinedNone
DeclinedNone
Resolvedmatej_suchanek
DeclinedNone
DeclinedNone
ResolvedNemo_bis
ResolvedAftabuzzaman

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

On-wiki issue, should not be tracked in phabricator, especially not against MediaWiki-extensions-Gadgets

Only English Wikipedia? Several gadgets have been broken on other high traffic wikis as well. It would be nice if those are fixed as well.

On-wiki issue, should not be tracked in phabricator, especially not against MediaWiki-extensions-Gadgets

From the home page, "Phabricator is a collaboration platform open to all Wikimedia and MediaWiki contributors. We focus on bug reporting and software projects. Non-technical initiatives are welcome as well." I don't really think it's a problem to track on wiki issues on Phabricator.

He7d3r renamed this task from Update broken gadgets on English Wikipedia to Update broken gadgets on WMF wikis.Aug 7 2015, 4:04 PM
He7d3r updated the task description. (Show Details)

Out of curiosity: Is it easy to get from the DB the number of legacy gadgets per WMF wiki?

I don't really think it's a problem to track on wiki issues on Phabricator.

It is, but please discuss the general issue in T85433 and T71445 instead.

Out of curiosity: Is it easy to get from the DB the number of legacy gadgets per WMF wiki?

You can use the API (https://en.wikipedia.org/w/api.php?action=query&list=gadgets&formatversion=2) and see if "legacyscripts" = true.

English Wikipedia has enough contributors not to need my services as global interface editor. I would rather not edit interface pages there unless there is an emergency.

Special:Gadgets displays an errorbox "Gadget is not loaded. Please migrate to ResourceLoader. (Learn more)" under each of these three gadgets. But there's no indication in User preferences > Gadgets that they're not loaded. Seems like a bug.

ImageAnnotator seemed to work for me anyway, the sandbox its help creates let me annotate an image.

The English Wikipedia gadgets are fixed now. Does anyone know of gadgets on other projects that are broken due to the ResourceLoader requirement, or should I close this bug for now?

It would be nice if https://meta.wikimedia.org/wiki/MediaWiki:Gadget-SBHandler.js could be fixed. Editing the huge page directly is a pita.

Does anyone know of gadgets on other projects that are broken due to the ResourceLoader requirement, or should I close this bug for now?

T108437: Added button groups to WikiEditor toolbar do not appear after MW ResourceLoader update (English Wikisource)

and potentially also T108863: Page namespace advanced editor toolbar position is broken on English Wikisource

kaldari renamed this task from Update broken gadgets on WMF wikis to Tracking: Update broken gadgets on WMF wikis.Aug 13 2015, 7:26 PM
kaldari added a project: Tracking-Neverending.

I've changed this into a tracking bug. Please add gadget specific bugs as blockers.

kaldari triaged this task as High priority.Aug 25 2015, 6:32 PM

@Aklapper: I know that Phabricator isn't usually the place to track broken gadgets, but there are so many gadgets that have broken recently (due to removal of sajax support, the new RL requirement, API changes, etc.) that it's something of a crisis. The Community Tech team would like to help the communities tackle this problem as it seems many of them lack the technical capacity to fix all the gadgets that no longer have active maintainers. If you have any suggestions for how to better organize this effort, let me know.

Probably, the vast majority of gadgets Wikimedia-wide were broken by the deprecations in the last few weeks. A start would be to use d072ac25a0d7d4ef4c94e99eaf079c7b3b91fdc1 and list all such "legacyscrips" gadgets across all wikis.

Niharika subscribed.

@Aklapper: I know that Phabricator isn't usually the place to track broken gadgets, but there are so many gadgets that have broken recently (due to removal of sajax support, the new RL requirement, API changes, etc.) that it's something of a crisis. The Community Tech team would like to help the communities tackle this problem as it seems many of them lack the technical capacity to fix all the gadgets that no longer have active maintainers. If you have any suggestions for how to better organize this effort, let me know.

Regarding "tracking gadget issues in Phabricator", see T85433#1549981 for my stance.
In short: If the Community-Tech team feels responsible I have no problem to see gadget related Phabricator tasks associated to the Community-Tech project. I'd just like to see Community-Tech clearly communicate their understanding of responsibility for such issues to avoid potential confusion and disappointment among involved parties.
Also, could you elaborate a bit on "how to better organize this effort"? Do you refer to organizing tasks in Phabricator itself, or rather communication with communities (like outside Phabricator)?

Should the Community-Tech team generally be CC'ed on gadget-related reports in Phabricator (e.g. T110333)?

I wonder if T106915 could help this job. If we had JavaScript errors logs and a smart way to query them, it would be vastly easier to find broken gadgets. Error volume is irrelevant, the true question is "what percentage of requests by A to wiki B get this JavaScript error?" where A is unregistered users/registered users/sysops/active users/people with gadget X enabled.

DannyH renamed this task from Tracking: Update broken gadgets on WMF wikis to Update broken gadgets on WMF wikis (tracking).Oct 28 2015, 7:42 PM

I wonder if T106915 could help this job.

I'm still wondering. :-) At least when JavaScript fails to execute altogether, having it logged somewhere would be nice.

Aklapper closed this task as Invalid.EditedJun 26 2019, 9:08 AM
Aklapper added a subscriber: TBolliger.

On-wiki content like user scripts, gadgets, templates, custom CSS are local features and managed independently on each wiki. Phabricator is used for MediaWiki, MediaWiki extensions, or server configuration, or by developers and teams to organize what they plan to work on. As @TBolliger removed Community-Tech from this task (which means that the Community-Tech team does not plan to work on this task) I am declining this task.

This is a matter to discuss and fix on the local wiki and not handled in Phabricator until https://phabricator.wikimedia.org/T121470 gets solved.

See https://www.mediawiki.org/wiki/Help:Locating_broken_scripts how you can find out why exactly a gadget is broken.
See https://www.mediawiki.org/wiki/ResourceLoader/Migration_guide_(users) and https://www.mediawiki.org/wiki/ResourceLoader/Legacy_JavaScript how you can fix that broken code.

The MediaWiki-extensions-Gadgets tag is about a PHP extension (see its description) and not a catch-all for random gadgets, hence removing tag.