Live Preview does not show the "Templates used in this preview" when section-editing
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Quiddity
	Jun 12 2015, 8:12 PM

Description

Without Live Preview:

If I edit the entire (random) page https://en.wikipedia.org/w/index.php?title=List_of_highways_numbered_192&action=edit I get a list of "Pages transcluded onto the current version of this page" (generally templates"
Similarly, if I edit the bottom section of that page, https://en.wikipedia.org/w/index.php?title=List_of_highways_numbered_192&action=edit&section=2 and click "Preview" once, I get a list of "Templates used in this preview" under the edit box.

With Live Preview, I don't get that list of templates/transclusions in the section-editing scenario.

Details

	Subject	Repo	Branch	Lines +/-
	LivePreview: Show "Templates used in this preview" when creating a new page or editing a section	mediawiki/core	master	+28 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		None	T41272 Bugs in "Live preview" feature (tracking)
		Resolved		Nardog	T102286 Live Preview does not show the "Templates used in this preview" when section-editing

Event Timeline

Quiddity created this task.Jun 12 2015, 8:12 PM

Quiddity raised the priority of this task from to Needs Triage.

Quiddity updated the task description. (Show Details)

Quiddity added projects: MediaWiki-Page-editing, JavaScript.

Quiddity subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2015, 8:12 PM

Quiddity added a parent task: T41272: Bugs in "Live preview" feature (tracking).Jun 12 2015, 8:13 PM

Quiddity updated the task description. (Show Details)Jun 12 2015, 8:38 PM

Quiddity set Security to None.

Ricordisamoa subscribed.Jun 12 2015, 8:47 PM

Markhurd subscribed.Jun 13 2015, 11:38 AM

Aklapper mentioned this in T172844: "Templates used in this preview" isn't working with "live preview".Aug 9 2017, 9:14 AM

MGChecker moved this task from Backlog to Live preview on the MediaWiki-Page-editing board.Nov 15 2018, 10:21 PM

Nardog subscribed.Apr 18 2020, 9:59 AM

The problem appears to be on line 207:

$editform.find( '.templatesUsed .mw-editfooter-list' ).detach().empty().append( newList ).appendTo( '.templatesUsed' );

This is assuming that $editform.find( '.templatesUsed .mw-editfooter-list' ) exists. But that's correct only while editing the whole page. While editing a section, .templatesUsed exists but is an empty div.

The code from non-live preview that constructs the div is at TemplatesOnThisPageFormatter.php which looks like lot to port to JavaScript.

@SD0001: Hi, do you plan to work on fixing this task, as you increased the priority of this task? If so, please set yourself as task assignee - thanks!

SD0001 raised the priority of this task from Medium to Needs Triage.Apr 19 2020, 9:27 AM

Change 631906 had a related patch set uploaded (by Gerrit Patch Uploader; owner: Nardog):
[mediawiki/core@master] LivePreview: Show "Templates used in this preview" when creating a new page or editing a section

https://gerrit.wikimedia.org/r/631906

gerritbot added a project: Patch-For-Review.Oct 3 2020, 7:30 AM

Change 631906 merged by jenkins-bot:
[mediawiki/core@master] LivePreview: Show "Templates used in this preview" when creating a new page or editing a section

https://gerrit.wikimedia.org/r/631906