Page MenuHomePhabricator
Create Task
Maniphest T100922

Create separate XMP parsing library
Closed, ResolvedPublic
Actions

Description

bawollf and I started hacking on this at the hackathon:

Dependencies left are wfTimestamp and wfSuppressWarnings/wfRestoreWarnings.

Details

SubjectRepoBranchLines +/-
Use wikimedia/xmp-reader librarymediawiki/coremaster+52 -3 K
Add wikimedia/xmp-reader 0.5.1mediawiki/vendormaster+3 K -3
Initial commitmediawiki/libs/XMPReadermaster+4 K -0
Move XMP* classes to includes/libsmediawiki/coremaster+14 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.May 31 2015, 8:20 AM
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added projects: MediaWiki-File-management, Librarization.
Legoktm added subscribers: Legoktm, Bawolff.
Restricted Application added a project: Multimedia. · View Herald TranscriptMay 31 2015, 8:20 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Legoktm added a comment.May 31 2015, 8:26 AM

https://gerrit.wikimedia.org/r/#/c/213355/ started moving stuff out of MWTimestamp so it too could be split out.

Legoktm closed subtask T100923: Create separate wfSuppressWarnings/wfRestoreWarnings library as Resolved.Jun 11 2015, 7:09 PM
Ricordisamoa subscribed.Aug 23 2015, 9:37 AM
Restricted Application added subscribers: Steinsplitter, Matanya. · View Herald TranscriptAug 23 2015, 9:37 AM
Krinkle moved this task from Untriaged to To Do on the Librarization board.Sep 4 2015, 4:06 AM
Jdforrester-WMF triaged this task as Low priority.Sep 4 2015, 6:55 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 7:00 PM
gerritbot subscribed.Sep 21 2016, 3:42 AM

Change 311907 had a related patch set uploaded (by Legoktm):
Move XMP* classes to includes/libs

https://gerrit.wikimedia.org/r/311907

Restricted Application added a project: Commons. · View Herald TranscriptSep 21 2016, 3:42 AM
gerritbot added a project: Patch-For-Review.Sep 21 2016, 3:42 AM
Restricted Application added a subscriber: Poyekhali. · View Herald TranscriptSep 21 2016, 3:42 AM
gerritbot added a comment.Sep 21 2016, 3:57 AM

Change 311907 merged by jenkins-bot:
Move XMP* classes to includes/libs

https://gerrit.wikimedia.org/r/311907

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)), MW-1.28-release-notes.Sep 21 2016, 4:00 AM
Legoktm mentioned this in T146884: Feature request: Turn /includes/media in to a PSR-4 composer package.Sep 28 2016, 10:01 AM
Legoktm added a comment.Oct 1 2016, 7:31 AM

@Bawolff T100924 is basically done, so we can go ahead and do this now :D Any opinions on naming? "XMP" or "XMPParser" or "XMPReader"?

Bawolff added a comment.Oct 6 2016, 11:54 PM

Woo!

XMPReader kind of sounds nice.

Krinkle closed subtask T100924: Split MWTimestamp into a separate library as Resolved.Mar 2 2017, 10:47 PM
Reedy removed projects: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)), Patch-For-Review.Apr 4 2017, 10:30 PM
gerritbot added a comment.Aug 17 2017, 3:19 AM

Change 372221 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/libs/XMPReader@master] Initial commit

https://gerrit.wikimedia.org/r/372221

gerritbot added a project: Patch-For-Review.Aug 17 2017, 3:19 AM
gerritbot added a comment.Sep 4 2017, 12:40 AM

Change 372221 merged by Legoktm:
[mediawiki/libs/XMPReader@master] Initial commit

https://gerrit.wikimedia.org/r/372221

Reedy moved this task from To Do to In Dev on the Librarization board.Sep 4 2017, 12:42 AM
Tgr awarded a token.Sep 5 2017, 12:01 AM
• demon subscribed.Feb 15 2018, 11:35 PM

The project was forked, I guess we just need to submit to packagist then add to vendor and remove the core bits? Should be easy to finish out :)

Legoktm added a comment.May 6 2018, 5:11 AM

Unfortunately the library fell behind core. I've manually cherry-picked the relevant commits in core to includes/libs after the fork:

f2f370cb31 Fix XMPReader/XMPValidator for PHP 7
966f541610 XMPReader: Log filename if available
93a38ae0ff xmp: Lower severity of XMP parse failure log events
1686d396db Group XMP parse failures by exception message

Some of the other codesniffer/at-ease stuff already happened in the library. Patches needing review: https://gerrit.wikimedia.org/r/#/q/project:mediawiki/libs/XMPReader+topic:sync-with-core

After those are merged, I think we can tag a release and bring it into core.

gerritbot added a comment.Jun 1 2018, 2:01 AM

Change 436711 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/vendor@master] Add wikimedia/xmp-reader 0.5.1

https://gerrit.wikimedia.org/r/436711

gerritbot added a comment.Jun 1 2018, 2:14 AM

Change 436713 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] Use wikimedia/xmp-reader library

https://gerrit.wikimedia.org/r/436713

gerritbot added a comment.Jun 1 2018, 2:36 AM

Change 436711 merged by jenkins-bot:
[mediawiki/vendor@master] Add wikimedia/xmp-reader 0.5.1

https://gerrit.wikimedia.org/r/436711

gerritbot added a comment.Jun 1 2018, 3:05 AM

Change 436713 merged by jenkins-bot:
[mediawiki/core@master] Use wikimedia/xmp-reader library

https://gerrit.wikimedia.org/r/436713

Legoktm closed this task as Resolved.Jun 1 2018, 3:09 AM
Legoktm claimed this task.

woohoo! Finished my 2015 hackathon project!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits