[twitch] Update is_live regex for VODs #6500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elyse0
added a commit
to elyse0/yt-dlp
that referenced
this pull request
Mar 12, 2023
Closes yt-dlp#6494 Authored by: elyse0
biolds
added a commit
to biolds/tubesync
that referenced
this pull request
Mar 28, 2023
This is required to fix Twitch is_live status (see yt-dlp/yt-dlp#6500)
qa4FKm3mUr
added a commit
to qa4FKm3mUr/yt-dlp
that referenced
this pull request
Jul 30, 2023
* [utils] Add hackish 'now' support for --download-sections * [utils] Add microseconds to unified_timestamp * [common] Extract start and end keys for Dash fragments * [utils] Allow using local timezone for 'now' timestamps * Use local timezone for download sections * Add fixme in modified parse_chapters function A range like '*(now-1hour)-(now-30minutes)' doesn't work * [youtube] Support --download-sections for YT Livestream from start * Create last_segment_url only if necessary * Improve parse_chapters comments * Fix linter * [extractor/iq] Set more language codes (yt-dlp#6476) Authored by: D0LLYNH0 * [extractor/opencast] Add ltitools to `_VALID_URL` (yt-dlp#6371) Authored by: C0D3D3V * [downloader/curl] Fix progress reporting Bug in 8c53322 Closes yt-dlp#6490 * [extractor/youtube] Bypass throttling for `-f17` and related cleanup Thanks @AudricV for the finding * [extractor/twitch] Fix `is_live` (yt-dlp#6500) Closes yt-dlp#6494 Authored by: elyse0 * [extractor/cbc:gem] Update `_VALID_URL` (yt-dlp#6499) Authored by: makeworld-the-better-one Closes yt-dlp#6395 * Support loading info.json with a list at it's root * [extractor/hidive] Fix login Fixes yt-dlp#6493 (comment) * [extractor/opencast] Fix format bug (yt-dlp#6512) Authored by: C0D3D3V * [extractor/rokfin] Re-construct manifest url (yt-dlp#6507) Authored by: vampirefrog * [extractor/youtube] Add client name to `format_note` when `-v` (yt-dlp#6254) Authored by: Lesmiscore, pukkandan * [extractor/youtube] Add extractor-arg `include_duplicate_formats` * [extractor/youtube] Construct fragment list lazily Building fragment list for all formats take significant time for large videos * Support negative durations * Revert "[utils] Allow using local timezone for 'now' timestamps" This reverts commit 1799a6a. * Add fragment count * Fix unified_timestamp * Remove tz_aware date code * Add debug for selected section * Add initial documentation * Fix linter * Fix linter * Allow days in parse_duration * Improve option documentation * Add some documentation * Lock less agressively This gives a speed performance of about 30% * Fix return values of _extract_sequence_from_mpd * Always compute last_seq * Support for epoch timestamps * Update options docs * Restore README.md I think this is auto-generated by some script * Add warning about --download-sections without --live-from-start * Fix bug after merge * Update yt_dlp/options.py * Cleanup --------- Co-authored-by: Elyse <[email protected]> Co-authored-by: Sophire <[email protected]> Co-authored-by: D0LLYNH0 <[email protected]> Co-authored-by: Daniel Vogt <[email protected]> Co-authored-by: pukkandan <[email protected]> Co-authored-by: makeworld <[email protected]> Co-authored-by: Daniel Vogt <[email protected]> Co-authored-by: vampirefrog <[email protected]> Co-authored-by: Lesmiscore <[email protected]> Co-authored-by: bashonly <[email protected]> Co-authored-by: bashonly <[email protected]>
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#6494 Authored by: elyse0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Twitch VOD extractor detects if a video is still live by looking for
404_processing_{width}x{height}in thepreviewThumbnailUrl, but GQL api now returns a slightly diferent url format.So this PR updates the check to use regex and match both cases
[ { "data":{ "user":null, "currentUser":null, "video":{ "id":"1760484475", "title":"MARIO PARTY CON EL TEAM TRYHARD HOY SE ROMPEN AMISTADES", "description":null, "previewThumbnailURL":"https://vod-secure.twitch.tv/_404/404_processing_90x60.png", "createdAt":"2023-03-09T23:32:00Z", "viewCount":1244, "publishedAt":"2023-03-09T23:32:00Z", "lengthSeconds":19163, "broadcastType":"ARCHIVE", "owner":{ "id":"211121982", "login":"vickypalami", "displayName":"vickypalami", "__typename":"User" }, "game":{ "id":"509658", "boxArtURL":"https://static-cdn.jtvnw.net/ttv-boxart/509658-{width}x{height}.jpg", ...Fixes #6494
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?