-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build!: drops Node 6 and 4. begin following Node.js LTS schedule #89
Conversation
@QmarkC thanks for the update. One thing on my mind, as we move towards the next major of each of yargs' dependencies, is if we can prefect the approach here then we should be able to ship a version of yargs that is fully functional in Node ESM, Node CJS, browser ESM, and Deno... This is completely unrelated to dropping old Node.js versions, except that I'd like to hold off on us taking the next breaking change for these libraries until we've dialed in the approach I'm describing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, only piece of feedback is, let's standardize on actions.
.travis.yml
Outdated
@@ -1,7 +1,9 @@ | |||
language: node_js | |||
sudo: false | |||
node_js: | |||
- "4" | |||
- "6" | |||
- "10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as we dust off these old libraries, let's switch to GitHub actions, and add automated publication/releasing, see:
https://github.com/yargs/yargs-parser/tree/master/.github/workflows
I can update the release-please.yml
with the publication logic, if you add ci.yml
for testing.
package.json
Outdated
}, | ||
"repository": { | ||
"type": "git", | ||
"url": "[email protected]:yargs/y18n.git" | ||
}, | ||
"license": "ISC", | ||
"author": "Ben Coe <[email protected]>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, but we should probably switch my email to [email protected]
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks \o/
@QmarkC I don't believe releases are setup on this repo yet, I'll do so and then merge this. |
This skips the EOL Node 8, and moves us to Node 10 as the supported Node.js version for y18n.