Provisional fix for wind stress limit error #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.03% // Head: 90.03% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
=======================================
Coverage 90.03% 90.03%
=======================================
Files 7 7
Lines 251 251
=======================================
Hits 226 226
Misses 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently aerobulk has limit of 5N/m^2 hardcoded. As discussed here we can probably update that value to at least 10N/m^2.
I have submitted a PR upstream to increase the limit.
This PR is swapping the submodule pointer from the upstream main repo to my personal PR branch (this SO post was very helpful) to implement this fix in our code base ASAP. As soon as this is fixed upstream, we should repoint to the official aerobulk repo.