Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[perl-xCAT] Allow mysqlsetup to configure mariadb too. #3398

Merged
merged 3 commits into from
Jul 11, 2017
Merged

[perl-xCAT] Allow mysqlsetup to configure mariadb too. #3398

merged 3 commits into from
Jul 11, 2017

Conversation

samveen
Copy link
Member

@samveen samveen commented Jul 5, 2017

While xCAT claims to support mariadb in addition to mysql, in the remote case where the service name is mariadb instead of mysql, the command mysqlsetup fails with the following error:

[root@xcatmn2 ~]# mysqlsetup -i
Input the alpha-numberic  password for xcatadmin in the MySQL database: 
Input the password for root in the MySQL database: 
 failed to start mysql/mariadb.

This PR allows mysqlsetup to work if the service name is mariadb instead of mysqld

@zet809 zet809 requested review from immarvin and cxhong July 5, 2017 08:44
@daniceexi daniceexi closed this Jul 5, 2017
@daniceexi daniceexi reopened this Jul 5, 2017
@xcatbot
Copy link

xcatbot commented Jul 5, 2017 •
edited
Loading

CI CHECK RESULT : > PR FORMAT CORRECT> BUILD SUCCESSFUL > INSTALL XCAT SUCCESSFUL> CODE SYNTAX CORRECT> FAST REGRESSION TEST Successful: Totalcase 214 Pass 214 failed 0

@cxhong
Copy link
Contributor

cxhong commented Jul 5, 2017

@samveen , what OS and Arch are running on?

@whowutwut
Copy link
Member

@hu-weihua Please review the travis changes

@whowutwut whowutwut requested a review from hu-weihua July 5, 2017 15:30
@samveen
Copy link
Member Author

samveen commented Jul 6, 2017 •
edited
Loading

@cxhong I'm running xCAT on CentOS 7.1

immarvin
immarvin approved these changes Jul 10, 2017
View reviewed changes
Copy link
Contributor

@immarvin immarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am ok with the modification in perl-xCAT/xCAT/Utils.pm

@cxhong
Copy link
Contributor

cxhong commented Jul 11, 2017

Verified changes and merge this. Will open another issue to support mysql/mariadb for centos

@cxhong cxhong merged commit a030a7f into xcat2:master Jul 11, 2017
@cxhong cxhong removed the request for review from hu-weihua July 11, 2017 20:18
@cxhong cxhong self-assigned this Jul 11, 2017
@cxhong cxhong removed their request for review July 11, 2017 20:19
@samveen samveen deleted the mariadbsetup branch July 13, 2017 04:37
@whowutwut whowutwut added this to the 2.13.6 milestone Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@immarvin immarvin immarvin approved these changes

Assignees

@cxhong cxhong

Labels
None yet
Projects
None yet
Milestone
2.13.6
Development

Successfully merging this pull request may close these issues.
6 participants
@samveen @xcatbot @cxhong @whowutwut @immarvin @daniceexi