This repository has been archived by the owner on Mar 1, 2019. It is now read-only.
linting: let CI fail if there are warnings #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that CI is able to pick liniting violation until tslint matures further: palantir/tslint#2604 This makes the output look slightly different but it contains the same information.
Previously warnings did not cause a non-0 exist code, slipped through CI. This cleans up after the change to liniting config.
jakobw
approved these changes
Nov 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that CI is able to pick up liniting violations until tslint matures
further: palantir/tslint#2604
This makes the output look slightly different but it contains the same
information.
Also cleans up some warnings that slipped through CI before.