Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify language rules #336

Merged
merged 4 commits into from
May 20, 2022
Merged

Simplify language rules #336

merged 4 commits into from
May 20, 2022

Conversation

edg2s
Copy link
Member

@edg2s Dec 7, 2020

Now that eslint-plugin-es-x contains rules for prototype properties,
we can do away with our not-es* rules and just rely on the plugin.

Copy link
Member Author

Depends on mysticatea/eslint-plugin-es#54

@jdforrester
Copy link
Member

Exciting.

@Krinkle Krinkle assigned Krinkle and unassigned Krinkle Dec 30, 2020
@jdforrester jdforrester mentioned this pull request Dec 31, 2020
3 tasks
force-pushed the languages branch 2 times, most recently from 588cff8 to a6ac7ac Compare September 4, 2021 23:12
@jdforrester
Copy link
Member

The upstream was merged but still hasn't been released. Time to fork?

@Krinkle
Copy link
Member

Krinkle commented May 18, 2022

The upstream was merged but still hasn't been released. Time to fork?

Looks like someone already did. Worth taking a look perhaps. They've done quite a bit more than just releasing already-merged patches, however, so there's a certain risk of divergence here. Having said that, they seem to be keeping compatibility and mention explicitly an intent to discontinue the fork when maintenance resumes.

mysticatea/eslint-plugin-es#72 (comment)

Now that eslint-plugin-es contains rules for prototype properties,
we can do away with our not-es* rules and just rely on the plugin.
@jdforrester jdforrester merged commit 2a707bc into master May 20, 2022
@jdforrester jdforrester deleted the languages branch May 20, 2022 14:06
@jdforrester jdforrester mentioned this pull request May 20, 2022
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants