Allow images without entrypoint with -e #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 45.31% 45.13% -0.18%
==========================================
Files 15 15
Lines 715 720 +5
==========================================
+ Hits 324 325 +1
- Misses 362 366 +4
Partials 29 29
Continue to review full report at Codecov.
|
tjamet
reviewed
Oct 25, 2020
cmd/install.go
Outdated
| if imageInspect.Config.Entrypoint == nil { | ||
| return fmt.Errorf("the image '%s' is not compatible with Whalebrew: it does not have an entrypoint", imageName) | ||
| if imageInspect.Config.Entrypoint == nil && customEntrypoint == "" { | ||
| return fmt.Errorf("The image '%s' does not have an entrypoint, please provide a custom entrypoint", imageName) |
There was a problem hiding this comment.
Shall we inform how to do so?
Suggested change
| return fmt.Errorf("The image '%s' does not have an entrypoint, please provide a custom entrypoint", imageName) | |
| return fmt.Errorf("The image '%s' does not have an entrypoint, please provide a custom entrypoint adding '--entrypoint my-program'", imageName) |
|
Awesome contrib! thanks! |
tjamet
approved these changes
Oct 25, 2020
|
Implemented your suggestion :) |
tjamet
approved these changes
Oct 26, 2020
|
thanks! va dentro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the only way around this is to create yaml file manually.