fix: unexpected asi generation with sequence expression

webpack · Aug 21, 2024 · b8c03d4 · b8c03d4
1 parent f46a03c
commit b8c03d4
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/lib/javascript/JavascriptParser.js b/lib/javascript/JavascriptParser.js
@@ -3096,11 +3096,13 @@ class JavascriptParser extends Parser {
 				currentStatement.expression === expression)
 		) {
 			const old = /** @type {StatementPathItem} */ (this.statementPath.pop());
+			const prev = this.prevStatement;
 			for (const expr of expression.expressions) {
 				this.statementPath.push(expr);
 				this.walkExpression(expr);
-				this.statementPath.pop();
+				this.prevStatement = this.statementPath.pop();
 			}
+			this.prevStatement = prev;
 			this.statementPath.push(old);
 		} else {
 			this.walkExpressions(expression.expressions);

diff --git a/test/cases/parsing/sequence-expression-asi/a.js b/test/cases/parsing/sequence-expression-asi/a.js
@@ -0,0 +1,3 @@
+export const fn = (num) => {
+	return num;
+};
diff --git a/test/cases/parsing/sequence-expression-asi/index.js b/test/cases/parsing/sequence-expression-asi/index.js
@@ -0,0 +1,21 @@
+import { fn } from "./a"
+
+function d() {}
+
+var num = 1
+d(), fn();
+
+export const b = 2
+d(), fn();
+
+export default (function Foo() {})
+d(), fn();
+
+export const c = 3
+function foo() {
+	d(), fn();
+}
+
+it("should work", function() {
+	expect(fn(num)).toBe(1);
+});