Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make removeTrack() a no-op after transceiver.stop() #2875

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented May 31, 2023

Fixes #2874.


Preview | Diff

@jan-ivar jan-ivar requested review from alvestrand, aboba and youennf May 31, 2023 21:22
@jan-ivar jan-ivar self-assigned this May 31, 2023
@henbos
Copy link
Contributor

henbos commented Jun 1, 2023

@youennf are you OK with this? Safari is the only one failing the test "Calling removeTrack on a stopped transceiver should be a no-op" which reflects this PR already

@jan-ivar
Copy link
Member Author

jan-ivar commented Jun 1, 2023

@youennf Does this seem good to you? Do we need a meeting you think or is this just another regression of the stopping/stopped feature that we already decided on how to solve?

@youennf
Copy link
Contributor

youennf commented Jun 15, 2023

Would be nice to file a bug on WebKit bug tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maybe removeTrack should be a no-op on [[Stopping]] as well as [[Stopped]]?
3 participants