Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up logic to support removal of RTCP mux "negotiated" value #1253

Closed
wants to merge 1 commit into from
Closed

clean up logic to support removal of RTCP mux "negotiated" value #1253

wants to merge 1 commit into from

Conversation

fluffy
Copy link
Contributor

@fluffy fluffy commented May 29, 2017

This PR makes it easier to remove this at risk value and at the same times makes the text better for future extensions that define new values.

@stefhak stefhak requested a review from jan-ivar June 1, 2017 14:30
@taylor-b
Copy link
Contributor

taylor-b commented Jun 1, 2017

I don't expect RTCRtcpMuxPolicy to be extended in the future; it's more likely it would be removed entirely. So, as long as there are only two possible values, and only one could possibly be unsupported, the existing text seems more clear than what this PR proposes.

jan-ivar
jan-ivar reviewed Jun 2, 2017
View reviewed changes
Copy link
Member

@jan-ivar jan-ivar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @taylor-b.

@stefhak
Copy link
Contributor

stefhak commented Jun 15, 2017

Seems people think this is not needed. closing.

@stefhak stefhak closed this Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-ivar jan-ivar jan-ivar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fluffy @taylor-b @stefhak @jan-ivar