Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excess parenthesis in text layout algorithm? ("Position on path" part) #382

Closed
fsoder opened this issue Jan 31, 2018 · 3 comments
Closed

Excess parenthesis in text layout algorithm? ("Position on path" part) #382

fsoder opened this issue Jan 31, 2018 · 3 comments
Labels
Needs tests
Milestone
SVG 2.0 Proposed ...

Comments

@fsoder
Copy link

fsoder commented Jan 31, 2018

In the "11.5. Text layout – Algorithm" [1], step 8.5.1.2.4, which reads:

Let offset be the value of the ‘textPath’ element's ‘startOffset’ attribute, adjusted due to any ‘pathLength’ attribute on the referenced element (if the referenced element is a ‘path’ element).

there's an additional restriction placed on when 'pathLength' applies ("if the referenced element is a ‘path’ element"). This restrictions seems to stem from the initial landing of the text layout algorithm. However (IIRC), since then all the basic shape elements gained 'pathLength' powers. Maybe this restriction (parenthesis) should be dropped?

[1] https://svgwg.org/svg2-draft/text.html#TextLayoutAlgorithm
@boggydigital boggydigital added this to the SVG 2.0 Recommendation milestone Jun 11, 2018
@boggydigital
Copy link
Contributor

Not blocking updated 2.0 CR publication - assigning 2.0 Recommendation milestone to clean this up before 2.0 REC

@Tavmjong
Copy link
Contributor

Yes, the parenthesis and text within should be dropped.

A test of Firefox and Chrome shows that they have implemented 'pathLength' on shapes (tested with 'stroke-dasharray' in both and also with 'startOffset' in Firefox 62).

@Tavmjong Tavmjong mentioned this issue Jun 28, 2018
Merged
Tavmjong added a commit to Tavmjong/svgwg that referenced this issue Jun 28, 2018
@Tavmjong
Remove unintended restriction that 'pathLength' only applied to paths…
5537551 
… and not shapes (for 'startOffset'). Fixes w3c#382.
@Tavmjong Tavmjong mentioned this issue Jun 28, 2018
Merged
@Tavmjong
Copy link
Contributor

Tests: web-platform-tests/wpt#11712
Spec: #476

Tavmjong added a commit to Tavmjong/svgwg that referenced this issue Jul 5, 2018
@Tavmjong
Remove unintended restriction that 'pathLength' only applied to paths…
2678036 
… and not shapes (for 'startOffset'). Fixes w3c#382.
@ewilligers ewilligers removed the Agenda+ label Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs tests
Projects
None yet
Milestone
SVG 2.0 Proposed Recommendation
Development

No branches or pull requests
5 participants
@boggydigital @ewilligers @dirkschulze @Tavmjong @fsoder