Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-inline] dominant-baseline initial value "normal" not mentioned anywhere else #4115

Closed
heycam opened this issue Jul 14, 2019 · 3 comments
Closed

[css-inline] dominant-baseline initial value "normal" not mentioned anywhere else #4115

heycam opened this issue Jul 14, 2019 · 3 comments
Labels
Closed Accepted as Obvious Bugfix css-inline-3 Current Work

Comments

@heycam
Copy link
Contributor

heycam commented Jul 14, 2019

https://drafts.csswg.org/css-inline-3/#dominant-baseline-property

The initial value normal isn't listed in the allowed values for the property. Is auto the intended initial value? (The css/css-inline/inheritance.html WPT tests for this normal value.)
@heycam heycam added the css-inline-3 Current Work label Jul 14, 2019
@ewilligers
Copy link
Contributor

ewilligers commented Jul 14, 2019 •
edited
Loading

Each browser has initial value auto. We should change the spec and the test.

https://wpt.fyi/results/css/css-inline/inheritance.html?label=master&label=experimental

@ewilligers
Copy link
Contributor

@fantasai Was this a typo when bringing the property across from SVG in 107993a ?

@fantasai
Copy link
Collaborator

fantasai commented Aug 7, 2019

@ewilligers Yes, I think so. I'll fix it. :)

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Aug 7, 2019
@ericwilligers @chromium-wpt-export-bot
CSS: Test dominant-baseline initial value 'auto'
15d1e47 
The CSS Inline Layout spec has been updated to
show the initial value of dominant-baseline as
'auto', matching SVG 1.1 and browsers.

https://drafts.csswg.org/css-inline/#dominant-baseline-property
w3c/csswg-drafts#4115

Change-Id: Ib2dbdf91a9535c4d149aa773b61302c36c360305
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Aug 8, 2019
@ericwilligers @chromium-wpt-export-bot
CSS: Test dominant-baseline initial value 'auto'
acd5e1a 
The CSS Inline Layout spec has been updated to
show the initial value of dominant-baseline as
'auto', matching SVG 1.1 and browsers.

https://drafts.csswg.org/css-inline/#dominant-baseline-property
w3c/csswg-drafts#4115

Change-Id: Ib2dbdf91a9535c4d149aa773b61302c36c360305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741445
Auto-Submit: Eric Willigers <[email protected]>
Commit-Queue: Emil A Eklund <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Cr-Commit-Position: refs/heads/master@{#685218}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Aug 8, 2019
@ericwilligers @chromium-wpt-export-bot
CSS: Test dominant-baseline initial value 'auto'
b1fd38d 
The CSS Inline Layout spec has been updated to
show the initial value of dominant-baseline as
'auto', matching SVG 1.1 and browsers.

https://drafts.csswg.org/css-inline/#dominant-baseline-property
w3c/csswg-drafts#4115

Change-Id: Ib2dbdf91a9535c4d149aa773b61302c36c360305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741445
Auto-Submit: Eric Willigers <[email protected]>
Commit-Queue: Emil A Eklund <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Cr-Commit-Position: refs/heads/master@{#685218}
aarongable pushed a commit to chromium/chromium that referenced this issue Aug 8, 2019
@ericwilligers
CSS: Test dominant-baseline initial value 'auto'
72c40b0 
The CSS Inline Layout spec has been updated to
show the initial value of dominant-baseline as
'auto', matching SVG 1.1 and browsers.

https://drafts.csswg.org/css-inline/#dominant-baseline-property
w3c/csswg-drafts#4115

Change-Id: Ib2dbdf91a9535c4d149aa773b61302c36c360305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741445
Auto-Submit: Eric Willigers <[email protected]>
Commit-Queue: Emil A Eklund <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Cr-Commit-Position: refs/heads/master@{#685218}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Aug 11, 2019
@ericwilligers @moz-wptsync-bot
Bug 1572239 [wpt PR 18325] - CSS: Test dominant-baseline initial valu…
2e24b7d 
…e 'auto', a=testonly

Automatic update from web-platform-tests
CSS: Test dominant-baseline initial value 'auto'

The CSS Inline Layout spec has been updated to
show the initial value of dominant-baseline as
'auto', matching SVG 1.1 and browsers.

https://drafts.csswg.org/css-inline/#dominant-baseline-property
w3c/csswg-drafts#4115

Change-Id: Ib2dbdf91a9535c4d149aa773b61302c36c360305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741445
Auto-Submit: Eric Willigers <[email protected]>
Commit-Queue: Emil A Eklund <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Cr-Commit-Position: refs/heads/master@{#685218}

--

wpt-commits: b1fd38d1568441ff1d6a93c04a7eedb5458cf30a
wpt-pr: 18325
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Aug 11, 2019
@ericwilligers @moz-wptsync-bot
Bug 1572239 [wpt PR 18325] - CSS: Test dominant-baseline initial valu…
0221fb3 
…e 'auto', a=testonly

Automatic update from web-platform-tests
CSS: Test dominant-baseline initial value 'auto'

The CSS Inline Layout spec has been updated to
show the initial value of dominant-baseline as
'auto', matching SVG 1.1 and browsers.

https://drafts.csswg.org/css-inline/#dominant-baseline-property
w3c/csswg-drafts#4115

Change-Id: Ib2dbdf91a9535c4d149aa773b61302c36c360305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741445
Auto-Submit: Eric Willigers <[email protected]>
Commit-Queue: Emil A Eklund <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Cr-Commit-Position: refs/heads/master@{#685218}

--

wpt-commits: b1fd38d1568441ff1d6a93c04a7eedb5458cf30a
wpt-pr: 18325
natechapin pushed a commit to natechapin/wpt that referenced this issue Aug 23, 2019
@ericwilligers @natechapin
CSS: Test dominant-baseline initial value 'auto'
4bd4059 
The CSS Inline Layout spec has been updated to
show the initial value of dominant-baseline as
'auto', matching SVG 1.1 and browsers.

https://drafts.csswg.org/css-inline/#dominant-baseline-property
w3c/csswg-drafts#4115

Change-Id: Ib2dbdf91a9535c4d149aa773b61302c36c360305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741445
Auto-Submit: Eric Willigers <[email protected]>
Commit-Queue: Emil A Eklund <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Cr-Commit-Position: refs/heads/master@{#685218}
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 4, 2019
@marco-c
Bug 1572239 [wpt PR 18325] - CSS: Test dominant-baseline initial valu…
8deed08 
…e 'auto', a=testonly

Automatic update from web-platform-tests
CSS: Test dominant-baseline initial value 'auto'

The CSS Inline Layout spec has been updated to
show the initial value of dominant-baseline as
'auto', matching SVG 1.1 and browsers.

https://drafts.csswg.org/css-inline/#dominant-baseline-property
w3c/csswg-drafts#4115

Change-Id: Ib2dbdf91a9535c4d149aa773b61302c36c360305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741445
Auto-Submit: Eric Willigers <ericwilligerschromium.org>
Commit-Queue: Emil A Eklund <eaechromium.org>
Reviewed-by: Emil A Eklund <eaechromium.org>
Cr-Commit-Position: refs/heads/master{#685218}

--

wpt-commits: b1fd38d1568441ff1d6a93c04a7eedb5458cf30a
wpt-pr: 18325

UltraBlame original commit: 1a862f3a6a2e47953c2455fef4ce80465959c40b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 4, 2019
@marco-c
Bug 1572239 [wpt PR 18325] - CSS: Test dominant-baseline initial valu…
f41ff82 
…e 'auto', a=testonly

Automatic update from web-platform-tests
CSS: Test dominant-baseline initial value 'auto'

The CSS Inline Layout spec has been updated to
show the initial value of dominant-baseline as
'auto', matching SVG 1.1 and browsers.

https://drafts.csswg.org/css-inline/#dominant-baseline-property
w3c/csswg-drafts#4115

Change-Id: Ib2dbdf91a9535c4d149aa773b61302c36c360305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741445
Auto-Submit: Eric Willigers <ericwilligerschromium.org>
Commit-Queue: Emil A Eklund <eaechromium.org>
Reviewed-by: Emil A Eklund <eaechromium.org>
Cr-Commit-Position: refs/heads/master{#685218}

--

wpt-commits: b1fd38d1568441ff1d6a93c04a7eedb5458cf30a
wpt-pr: 18325

UltraBlame original commit: 1a862f3a6a2e47953c2455fef4ce80465959c40b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 4, 2019
@marco-c
Bug 1572239 [wpt PR 18325] - CSS: Test dominant-baseline initial valu…
4d6b6cc 
…e 'auto', a=testonly

Automatic update from web-platform-tests
CSS: Test dominant-baseline initial value 'auto'

The CSS Inline Layout spec has been updated to
show the initial value of dominant-baseline as
'auto', matching SVG 1.1 and browsers.

https://drafts.csswg.org/css-inline/#dominant-baseline-property
w3c/csswg-drafts#4115

Change-Id: Ib2dbdf91a9535c4d149aa773b61302c36c360305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741445
Auto-Submit: Eric Willigers <ericwilligerschromium.org>
Commit-Queue: Emil A Eklund <eaechromium.org>
Reviewed-by: Emil A Eklund <eaechromium.org>
Cr-Commit-Position: refs/heads/master{#685218}

--

wpt-commits: b1fd38d1568441ff1d6a93c04a7eedb5458cf30a
wpt-pr: 18325

UltraBlame original commit: 1a862f3a6a2e47953c2455fef4ce80465959c40b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted as Obvious Bugfix css-inline-3 Current Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fantasai @ewilligers @heycam