Make callback optional when providing context #7098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise TypeScript compiler complains about `not assignable to parameter of type 'RenderCallback'`
|
Thanks for the PR - it actually is missing the Promise-based overload signature. |
|
oh, you already added missing signature, neat 👍 |
|
Please also add promise-with-context signature to renderToString(vm: Vue, context: object): Promise<string>;should i submit a new PR? |
|
done in 14e9908 |
|
thanks |
lovelope
pushed a commit
to lovelope/vue
that referenced
this pull request
Feb 1, 2018
…uejs#7098) * Make callback optional when providing context Otherwise TypeScript compiler complains about `not assignable to parameter of type 'RenderCallback'` * Update index.d.ts
…uejs#7098) * Make callback optional when providing context Otherwise TypeScript compiler complains about `not assignable to parameter of type 'RenderCallback'` * Update index.d.ts
…uejs#7098) * Make callback optional when providing context Otherwise TypeScript compiler complains about `not assignable to parameter of type 'RenderCallback'` * Update index.d.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
TypeScript compiler complains about
not assignable to parameter of type 'RenderCallback'Does this PR introduce a breaking change? (check one)