Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] OVF file uploads not using absolute path #3555

Closed
Xiol opened this issue Sep 20, 2024 · 2 comments · Fixed by #3596
Closed

[BUG] OVF file uploads not using absolute path #3555

Xiol opened this issue Sep 20, 2024 · 2 comments · Fixed by #3596

Comments

@Xiol
Copy link
Contributor

Xiol commented Sep 20, 2024

Describe the bug
Similar to #3550, the actual file uploads that Importer.Upload() attempts are done via relative paths. This results in the file not being found when the upload is attempted from a different working directory when using importer.Importer from another application.

To Reproduce
Steps to reproduce the behavior:

  1. Attempt to upload an OVF using importer.Importer while having your working directory different to the OVF path.
  2. Notice that the upload fails to find some of the files.

Expected behavior
The upload should happen successfully regardless of the current working directory.

Affected version
v0.43.0

Screenshots/Debug Output
N/A

Additional context
N/A

Copy link
Contributor

Howdy 🖐   Xiol ! Thank you for your interest in this project. We value your feedback and will respond soon.

If you want to contribute to this project, please make yourself familiar with the CONTRIBUTION guidelines.

@Xiol
Copy link
Contributor Author

Xiol commented Oct 17, 2024

After further investigation this appears to have been caused by the FileArchive.Open() function not handling paths in a cross-platform manner (our code unfortunately targets Windows machines). I've opened another PR to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant