Add detection for new bun text lockfile #12740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 572ba6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TooTallNate
approved these changes
Dec 12, 2024
EndangeredMassa
approved these changes
Dec 12, 2024
| cliType = 'bun'; | ||
| lockfilePath = bunLockPath; | ||
| // TODO: read "bun-lockfile-format-v0" | ||
| lockfileVersion = 0; | ||
| lockfileVersion = bunLockTextPath ? 1 : 0; |
There was a problem hiding this comment.
suggestion (soft-blocking): read actual lockfile version
I don't think we should use lockfileVersion in this way. The version can still be 0 in the text-based format. This value could produce confusing results in the future.
It looks like this is being used later to output the lockfile name itself. This is brittle for future changes. We should find a more explicit way to track the lockfile name used.
There was a problem hiding this comment.
Thanks, will make this change in a follow up PR!
Merged
EndangeredMassa
pushed a commit
that referenced
this pull request
Dec 12, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/[email protected] ### Major Changes - update path-to-regexp ([#12734](#12734)) ### Patch Changes - Updated dependencies \[[`7c3114ff8a1bdf0933c008a83e46c3d8f6dfcf7d`](7c3114f)]: - @vercel/[email protected] ## @vercel/[email protected] ### Major Changes - Bump path-to-regexp from 6.2.1 to 6.3.0 ([#12744](#12744)) ## @vercel/[email protected] ### Major Changes - update path-to-regexp ([#12734](#12734)) ## @vercel/[email protected] ### Minor Changes - Add bun detection using bun.lock ([#12740](#12740)) ## @vercel/[email protected] ### Minor Changes - Add bun detection using bun.lock ([#12740](#12740)) ### Patch Changes - Updated dependencies \[[`0c4ce9cfbf0c6d3108656584d56fa501e3efe15e`](0c4ce9c)]: - @vercel/[email protected] ## [email protected] ### Patch Changes - Fix hanging command when `spawn()` fails during CLI extension invocation ([#12735](#12735)) - Update to v2 endpoints for fetching integrations and installations ([#12721](#12721)) - Bug fix: new integrations using protocols for storage category can be created via the CLI wizard ([#12733](#12733)) - [cli] expand cache boundary ([#12726](#12726)) - bump cookie and sentry/node ([#12739](#12739)) - Updated dependencies \[[`7c3114ff8a1bdf0933c008a83e46c3d8f6dfcf7d`](7c3114f), [`0c4ce9cfbf0c6d3108656584d56fa501e3efe15e`](0c4ce9c), [`bcb9fbe059a017cf78ed2d7b15991d704beb4cf8`](bcb9fbe)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`7c3114ff8a1bdf0933c008a83e46c3d8f6dfcf7d`](7c3114f), [`0c4ce9cfbf0c6d3108656584d56fa501e3efe15e`](0c4ce9c)]: - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`7c3114ff8a1bdf0933c008a83e46c3d8f6dfcf7d`](7c3114f), [`0c4ce9cfbf0c6d3108656584d56fa501e3efe15e`](0c4ce9c)]: - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`0c4ce9cfbf0c6d3108656584d56fa501e3efe15e`](0c4ce9c)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`7c3114ff8a1bdf0933c008a83e46c3d8f6dfcf7d`](7c3114f), [`0c4ce9cfbf0c6d3108656584d56fa501e3efe15e`](0c4ce9c)]: - @vercel/[email protected] - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 1.2, bun will use a text
bun.lockinstead of binarybun.lockb: https://x.com/bunjavascript/status/1866879040424120625The text lockfile can be used now on bun canary when using
--save-text-lockfile.