Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uv in check_requirements #18116

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Use uv in check_requirements #18116

wants to merge 13 commits into from

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Dec 9, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved dependency installation by adding support for uv, a faster package manager, as a fallback mechanism.

πŸ“Š Key Changes

  • Added a check for the uv package manager using importlib.
  • Updated the attempt_install function to use uv for faster installations when available, falling back to pip otherwise.
  • Adjusted installation command to dynamically switch between uv and pip as needed.

🎯 Purpose & Impact

  • πŸš€ Faster Installs: Speeds up dependency installations when uv is available, improving efficiency.
  • πŸ”„ Enhanced Flexibility: Provides a seamless fallback to pip, ensuring compatibility in all environments.
  • 🌟 User-Friendly: Users with uv installed will benefit from quicker installations without manual setup.

Signed-off-by: Glenn Jocher <[email protected]>
@UltralyticsAssistant UltralyticsAssistant added dependencies Dependencies and packages enhancement New feature or request labels Dec 9, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/ultralytics πŸš€ PR! To ensure a smooth review and integration process, please review the checklist below:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description and link any relevant issues. Ensure your commit messages are clear, concise, and follow the project's conventions.
  • βœ… Synchronize with Source: Make sure your PR is up-to-date with the main branch of ultralytics/ultralytics. If it isn't, you can update it by clicking the 'Update branch' button or using git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify that all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, address them to ensure compatibility.
  • βœ… Update Documentation: If applicable, update the documentation to reflect your changes and help users understand the new functionality.
  • βœ… Add Tests: If your PR includes new features or fixes, include appropriate tests and confirm that all existing tests pass successfully.
  • βœ… Sign the CLA: If this is your first contribution to Ultralytics, ensure you’ve signed our Contributor License Agreement (CLA) by adding "I have read the CLA Document and I sign the CLA" in a new comment.
  • βœ… Minimize Changes: Keep your changes limited to the minimum required for your feature or fix. It’s a great reminder to focus on efficiency and simplicity: "It is not daily increase but daily decrease, hack away the unessential." β€” Bruce Lee

For further details about contributing, please see our Contributing Guide.

This is an automated response to assist with the PR process 😊. An Ultralytics engineer will review your submission soon and provide further feedback or approval. Thank you for contributing to Ultralytics! πŸš€

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 73.05%. Comparing base (a7f72d3) to head (0da9beb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18116      +/-   ##
==========================================
- Coverage   73.68%   73.05%   -0.63%     
==========================================
  Files         129      129              
  Lines       17307    17311       +4     
==========================================
- Hits        12752    12646     -106     
- Misses       4555     4665     +110     
Flag Coverage Ξ”
Benchmarks 33.96% <80.00%> (-0.89%) ⬇️
GPU 38.23% <0.00%> (-0.01%) ⬇️
Tests 67.40% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies and packages enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants