-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes try-except from torch_utils/profile
#16750
base: main
Are you sure you want to change the base?
Conversation
π Hello @Burhan-Q, thank you for submitting an ultralytics/ultralytics π PR! This is an automated response, and an Ultralytics engineer will also assist you soon. To ensure a seamless integration of your work, please review the following checklist:
For more guidance, please refer to our Contributing Guide. If your PR addresses a bug, please include a minimum reproducible example (MRE) to assist with verification. Thank you for contributing to Ultralytics! We appreciate your efforts and look forward to reviewing your improvements. ππ |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #16750 +/- ##
==========================================
- Coverage 74.01% 73.96% -0.05%
==========================================
Files 128 128
Lines 17138 17134 -4
==========================================
- Hits 12684 12674 -10
- Misses 4454 4460 +6
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
@Burhan-Q this might not be a bad idea! Let's try it! |
@Burhan-Q oh but wait, then with this change we'll have a super fast backwards pass time showing in the profiling, so we actually want an NaN to show here if the operation has no backwards pass. |
Updated to |
Thank you for the update! Using |
π οΈ PR Summary
Made with β€οΈ by Ultralytics Actions
π Summary
Improved error handling for backward operations in the
profile
function.π Key Changes
try-except
block with a more concisegetattr
approach to handle backward operation checks.π― Purpose & Impact