Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated stale actions rules #16563

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Updated stale actions rules #16563

wants to merge 15 commits into from

Conversation

ambitious-octopus
Copy link
Member

@ambitious-octopus ambitious-octopus commented Sep 30, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved the GitHub workflow for handling stale pull requests.

πŸ“Š Key Changes

  • Added configurations to ignore updates on pull requests, reducing unnecessary processing.
  • Opted not to remove the stale label when pull requests are updated.
  • Enabled focusing on only assigned pull requests for stale-check criteria.

🎯 Purpose & Impact

  • Efficiency Boost: By ignoring pull request updates and focusing only on assigned PRs, the workflow reduces noise and improves clarity for maintainers. πŸš€
  • Resource Management: Helps maintainers better prioritize and manage their workload by keeping attention on relevant PRs. πŸ”
  • Community Engagement: Ensures contributors receive timely feedback and maintain engagement by highlighting the need for updates on inactive pull requests. πŸ’¬

@ambitious-octopus ambitious-octopus self-assigned this Sep 30, 2024
@ambitious-octopus ambitious-octopus marked this pull request as draft September 30, 2024 10:53
@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops enhancement New feature or request labels Sep 30, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @ambitious-octopus, thank you for submitting an ultralytics/ultralytics πŸš€ PR! This is an automated response, but rest assured that an Ultralytics engineer will assist you soon. Please review the following checklist to ensure a smooth integration:

  • βœ… Define a Purpose: Clearly explain the purpose of your changes in your PR description and link to any relevant issues. Make sure your commit messages are clear and follow project conventions.
  • βœ… Synchronize with Source: Ensure your PR is synchronized with the ultralytics/ultralytics main branch. If it’s outdated, update it using the 'Update branch' button or by executing git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Confirm all Ultralytics Continuous Integration (CI) checks are passing. Address any issues if checks fail.
  • βœ… Update Documentation: For any new or modified features, update the relevant documentation.
  • βœ… Add Tests: Where applicable, include or update tests to cover your changes and ensure all tests are passing.
  • βœ… Sign the CLA: If this is your first Ultralytics PR, please sign our Contributor License Agreement by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Restrict changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

For more guidance, refer to our Contributing Guide. If you have any questions, feel free to leave a comment. Thank you for contributing to Ultralytics! πŸš€

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 74.01%. Comparing base (e0f8eda) to head (0cef146).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16563   +/-   ##
=======================================
  Coverage   74.01%   74.01%           
=======================================
  Files         128      128           
  Lines       17138    17138           
=======================================
  Hits        12684    12684           
  Misses       4454     4454           
Flag Coverage Ξ”
Benchmarks 35.02% <ΓΈ> (ΓΈ)
GPU 38.47% <ΓΈ> (ΓΈ)
Tests 67.75% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@glenn-jocher
Copy link
Member

@ambitious-octopus times are too aggressive here, should leave as is, but I like these first 3 lines. Can you just leave them?

      ignore-pr-updates: true
      remove-pr-stale-when-updated: false
      include-only-assigned: true

Copy link
Member Author

@ambitious-octopus ambitious-octopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glenn-jocher Updated!

@ambitious-octopus ambitious-octopus marked this pull request as ready for review October 18, 2024 07:55
@ambitious-octopus ambitious-octopus added the TODO High priority items label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops enhancement New feature or request TODO High priority items
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants