-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement right join and outer join #96
Comments
Quick questions:
|
|
Would be nice to have |
There is internal code for |
…ing that the columns are in the ight order. #96
I've added the generic and the methods for data.frame and |
Getting this for
Let me know if this is what you expect. I'm transferring this one to you @hadley as it's now about making the other various methods and documentation. |
I get strange results with (a <- data.frame(x = 1:5, y = 2:6))
(b <- data.frame(x = 3:7, z = 4:8))
right_join(a, b)
left_join(b, a) Actually run > (a <- data.frame(x = 1:5, y = 2:6))
x y
1 1 2
2 2 3
3 3 4
4 4 5
5 5 6
> (b <- data.frame(x = 3:7, z = 4:8))
x z
1 3 4
2 4 5
3 5 6
4 6 7
5 7 8
> right_join(a, b)
Joining by: "x"
x y z
1 3 4 4
2 4 5 5
3 5 6 6
4 3 NA 7
5 3 NA 8
> left_join(b, a)
Joining by: "x"
x z y
1 3 4 4
2 4 5 5
3 5 6 6
4 6 7 NA
5 7 8 NA It seems like the last two elements of |
The fix introduced by c9bea13 clears up the bug explored in my example above, so that's RESOLVED. |
is it worth implementing "left" and "right" versions of |
Any chance we'll have methods for tbl_sql for these joins? I am not sure if it's included in "add methods for everything" |
@piccolbo can you please open a new issue so I don't lose track of this? |
Since they probably are common enough to be worthwhile
The text was updated successfully, but these errors were encountered: