Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-fd-util: drop dead code #35662

Merged
merged 1 commit into from
Dec 18, 2024
Merged

data-fd-util: drop dead code #35662

merged 1 commit into from
Dec 18, 2024
+2 −35

Conversation

yuwata
Copy link
Member

@yuwata yuwata commented Dec 18, 2024

Follow-ups for a87a962.
Fixes CID#1568419.

@github-actions github-actions bot added util-lib please-review PR is ready for (re-)review by a maintainer labels Dec 18, 2024
YHNdnzj
YHNdnzj approved these changes Dec 18, 2024
View reviewed changes
src/shared/data-fd-util.c Show resolved Hide resolved
@YHNdnzj YHNdnzj added good-to-merge/with-minor-suggestions and removed please-review PR is ready for (re-)review by a maintainer labels Dec 18, 2024
@poettering
Copy link
Member

oh, indeed. lgtm!

@yuwata yuwata mentioned this pull request Dec 18, 2024
Merged
@yuwata
data-fd-util: drop dead code
beeee13 
Also drops unnecessary header inclusions.

Follow-ups for a87a962.
Fixes CID#1568419.
@yuwata yuwata force-pushed the data-fd-util-follow-ups branch from d260751 to beeee13 Compare December 18, 2024 10:41
@yuwata yuwata added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed good-to-merge/with-minor-suggestions labels Dec 18, 2024
@poettering poettering merged commit 114453d into systemd:main Dec 18, 2024
40 of 46 checks passed
@github-actions github-actions bot removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Dec 18, 2024
@yuwata yuwata deleted the data-fd-util-follow-ups branch December 18, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YHNdnzj YHNdnzj YHNdnzj approved these changes

Assignees
No one assigned
Labels
util-lib
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuwata @poettering @YHNdnzj