Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Util functions from CableReady #623

Merged
merged 2 commits into from
Jan 15, 2023
Merged

Use Util functions from CableReady #623

merged 2 commits into from
Jan 15, 2023

Conversation

marcoroth
Copy link
Member

@marcoroth marcoroth commented Jan 15, 2023 •
edited
Loading

Type of PR

Enhancement

Description

Use XPathToElement, XPathToArray, debounce and dispatch from CableReady. Enabled via stimulusreflex/cable_ready#236

Resolves #571

Why should this be added

Less code and code sharing is always good.

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing
  • This is not a documentation update

@marcoroth marcoroth added enhancement New feature or request cableready labels Jan 15, 2023
@marcoroth marcoroth merged commit bffce34 into stimulusreflex:master Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cableready enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hoist parts of utils.js to CableReady or reuse methods already present there
1 participant
@marcoroth