Fix -Wreturn-type and its undefined behavior #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silence the following warning message: src/NotesWriterSM.cpp:260:11: warning: control reaches end of non-void function [-Wreturn-type] This warning had meaningful implications for some reason. When I compiled the current version with stack protector enabled, GCC optimized out successful return from the function, and encouraged undefined behavior far less intuitive than an unspecified value. Whenever saving a steps file on a -DCMAKE_BUILD_TYPE=Release build, the game printed a message about stack protection violation, and aborted itself, even though no violation took place. GCC version: gcc (Gentoo 10.2.0 p1) 10.2.0
|
LGTM
- Colby
…On Tue, Sep 15, 2020 at 2:43 PM quietly-turning ***@***.***> wrote:
Thanks for another patch, @Arusekk <https://github.com/Arusekk>!
Similar to #2012 <#2012>, this
is outside my working knowledge, but perhaps this comment can draw the
attention of any active devs who are more familiar with it. 🙂
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2043 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABVS5SOJYRGZVTJIF5JGTLSF7NYBANCNFSM4PK3NQPQ>
.
|
|
Thanks, shake. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silence the following warning message:
This warning had meaningful implications for some reason.
When I compiled the current version with stack protector enabled, GCC optimized out successful return from the function, and encouraged undefined behavior far less intuitive than an unspecified value.
Whenever saving a steps file on a
-DCMAKE_BUILD_TYPE=Releasebuild, the game printed a message about stack protection violation, and aborted itself, even though no violation took place.GCC version:
gcc (Gentoo 10.2.0 p1) 10.2.0