-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace IClickAlert with events #30728
Merged
metalgearsloth
merged 3 commits into
space-wizards:master
from
EmoGarbage404:alert-events
Aug 7, 2024
Merged
Replace IClickAlert with events #30728
metalgearsloth
merged 3 commits into
space-wizards:master
from
EmoGarbage404:alert-events
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmoGarbage404
requested review from
metalgearsloth,
Jezithyr and
Partmedia
as code owners
August 7, 2024 03:20
github-actions
bot
added
the
S: Needs Review
Status: Requires additional reviews before being fully accepted
label
Aug 7, 2024
themias
pushed a commit
to themias/space-station-14
that referenced
this pull request
Aug 9, 2024
* Replace IAlertClick with events * whoop * eek!
Ilya246
added a commit
to Ilya246/space-station-14
that referenced
this pull request
Oct 10, 2024
* Fix Bwoink Player sorting again.... (space-wizards#30580) Keep players that have had messages in the round at the top * Automatic changelog update * Marathon had extra pipes under windows (space-wizards#30584) Deletes extra pipes * Packed Singulo Substation & Chemistry Windoors (space-wizards#30572) * Rearrange Engineering Wires * Replaces chemistry windoors with correct access * Toxins Guidebook spelling mistakes (space-wizards#30585) Corrects spelling mistakes and changes dosages to doses * Recolor winter boots (space-wizards#30350) * Recolor winter boots * fix inhands * better colors * FOOT * Automatic changelog update * Greyscale Winter Coats and Hoods, some reorganizing of rsi. (space-wizards#30314) * reorganize coats, greyscale coats and hoods * fix inhands * make rsi validator happy * even mo' hap' * comma schmomma * oops theres a recipe * armor credits * painflicts * Add Ngl to chatsan (space-wizards#30589) * Ngl added fr this time * Update speech-chatsan.ftl Not gonna lie sounds more realistic than not going to lie * Display the administrator's title in ahelp and ahelp relay (space-wizards#30075) * Adding the admin prefix to the ahelp * Updating the admin prefix * The second update of the admin prefix * Configuration correction * Shotgun spread refactor (space-wizards#27773) * Moves spread data to new component * Refactors shotgun spread code * Makes shotgun cartridges and projectiles use new component * Attempts to fix nullable build error * Fixes hitscan weapons that I broke :( * Saviour commit? --------- Co-authored-by: EmoGarbage404 <[email protected]> * SpeakOnUseSystem and phrases for figurines (space-wizards#30455) * commit 1 * 2 * add more text * apply review * apply review 2 Co-authored-by: slarticodefast <[email protected]> --------- Co-authored-by: slarticodefast <[email protected]> * Automatic changelog update * Made the dank pizza actually dank (space-wizards#30430) * made the dank pizza actually dank * made the dank pizza also contain some nutritional value * Automatic changelog update * fix(GhostRoleAntagSpawner): Create a new mind before transfering (space-wizards#30354) * IN MY WALLS! IN MY WALLS THEY ARE IN MY WALLS HELP HEELP HEKP PA DADOEAMD EODM AOM D *DIES* IM NOT DEAD ADADADDADIAMSDIM * RUN I SAID RUN! THEY TOOK MY UKELELE Co-authored-by: EmoGarbage404 <[email protected]> * Many have fallen * It's all emo's fault --------- Co-authored-by: EmoGarbage404 <[email protected]> * Docking ports now block air only in the direction their port is. (space-wizards#30195) speedholes. * Fix a typo in the raid suit's description (space-wizards#30612) fix typo (for real this time i swear) * Update Credits (space-wizards#30620) Co-authored-by: PJBot <[email protected]> * Add mapping editor (space-wizards#23427) * Add mapping editor (space-wizards#757) * Remove mapping actions, never again * Cleanup actions system * Jarvis, remove all references to CM14 * Fix InventoryUIController crashing when an InventoryGui is not found * Rename mapping1 to mapping * Clean up context calls * Add doc comments * Add delegate for hiding decals in the mapping screen * Jarvis mission failed * a * Add test * Fix not flushing save stream in mapping manager * change * Fix verbs * fixes * localise --------- Co-authored-by: DrSmugleaf <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> * added relevant guides to help menus (space-wizards#30462) * added relevant guides to help menus * fixed ALL missing help-menu links * missed one * fix(ChargerSystem): Don't show battery level twice. (space-wizards#30625) * Automatic changelog update * Make pointing cooldown a cvar (space-wizards#30623) * Make pointing cooldown a cvar * Remove empty line * Don't show toggle internals verb if no breath tools are found while off (space-wizards#30622) * Don't show toggle internals verb if no breath tools are found * only if not working * Automatic changelog update * fix(Solutions): Implement missing bounds check (space-wizards#30239) * Fix verbs in mapping state (space-wizards#30631) * Remove unused variable from ThownInsertContainerSystem (space-wizards#30611) * replace all uses of TryGetContainingContainer with non-obsolete overload (space-wizards#30583) * replace all uses of TryGetContainerContainer with non-obsolete overload * rerun * Give rotten meat `Trash` and `Recyclable` tag (space-wizards#30594) * Automatic changelog update * Meta Robotics Console (space-wizards#30652) Adds robotics console to Meta * Cluster Christmas Removal (space-wizards#30635) No Fun Allowed * Update Core (space-wizards#30633) add * Box Atmos Miners Grille Removal (space-wizards#30610) Removes Grilles from around atmos miners * Fland Atmos Gas Miners Grille Removal (space-wizards#30615) Removes grilles from atmos gas miners on Fland * fml to chatsan (space-wizards#30651) * tweak(grammar): Correct multiple instances of incorrect "it's" usage (space-wizards#30641) * tweak(grammar): Correct multiple instances of incorrect "its" usage (space-wizards#30640) * Fix GhostRoleRadio icons (space-wizards#30650) Co-authored-by: plykiya <[email protected]> * Fix falsely showing damage color effect to entities that aren't allowed to be attacked (space-wizards#30661) * Explosion resistance is now predicted! (space-wizards#30654) * First commit * Added Network and access * Automatic changelog update * Fix some descriptions (space-wizards#30644) * Improve communications console countdown formatting (space-wizards#30495) * improve communications console countdown formatting * tostring * Gets rid of all leftover usages of IEyeManager.CurrentMap (space-wizards#30022) * Gets rid of all leftover usages of CurrentMap * args works * reverty * skill issue --------- Co-authored-by: plykiya <[email protected]> * Sleeper agents event no longer occurs when evacuation is called (space-wizards#30646) no more evac sleeper agents * Automatic changelog update * Give Mice Combat Mode and a 0 Damage Attack (space-wizards#30487) * Automatic changelog update * Fix warnings in ShuttleSystem.GridFill.cs (space-wizards#30253) * Fix warnings in ShuttleSystem.GridFill.cs * remove the thingie --------- Co-authored-by: metalgearsloth <[email protected]> * Move PaperSystem to Shared (space-wizards#30592) * Fix paper system late localization * IS THIS WHAT YOU WANT * well I guess this is happening now * fix the BUI * did that even do anything before? * again with the escapeformatting... * Dirtying * Move dirty to function * Rename PaperSystem to PaperVisualizerSystem * Fix namespace * how many namespace changes must I suffer through * SetContent is for Setting Content * minor shuffling * review --------- Co-authored-by: plykiya <[email protected]> Co-authored-by: metalgearsloth <[email protected]> * JobRequirement refactor (space-wizards#30347) * refactor JobRequirements * add profile support * fix * Update quartermaster.yml * sloth fixes * inport 30208 * Update DepartmentPrototype.cs * species restriction * left tweak stick * stringbuilder is cool! * Automatic changelog update * Restore the longer traitor briefing message (space-wizards#30404) * Restore the long traitor briefing * highlights * De-duplicate loadout gear (space-wizards#30341) * De-duplicate loadout gear Needs supporting code, probably with an interface with StartingGearPrototype which would also use it, but I regexed the yaml. * Code updates * Remaining yaml * Fix automatic naming * raiseEvent * Don't code when tired kids * Change the mimebot and killer tomato's descriptions (space-wizards#30639) fix those two descriptions * Update submodule to 229.1.0 (space-wizards#30664) * add(Spawners): Add a honk bot spawner (space-wizards#30616) * Missing mime mask sprites for Vox (space-wizards#30607) mime-mask-vox * Automatic changelog update * Debug command to set either your hunger or thirst to one of their respective threshold levels (space-wizards#30563) * Debug command to set either your hunger or thirst to one of their respective threshold levels * code updates * code + loc changes * Automatic changelog update * Fix random unused field warnings (space-wizards#29948) * Fix random unused field warnings Not many but it counts. * caught * Field * Change Thief Syndie & Chameleon kit contents, add Syndie codeword paper (space-wizards#30446) * Initial commit * more like bYE * Fix exception during test * Automatic changelog update * Add slowdown to low temperatures (space-wizards#29692) * TemperatureSpeed component * temperature slowdown prediction (done right) * remove unnecessary changes * that too * get in line * make it readonly * auto pause * Automatic changelog update * Refactor the `hungry` debug command to be in line with `thirsty` (space-wizards#30591) refactor the hungry debug command to be in line with thirsty Co-authored-by: metalgearsloth <[email protected]> * Fix verb sub (space-wizards#30667) * Fix verb sub Mapping casualty, verbs are weird. * also this * tweak(SolutionTransfer): Raise default max transfer amount. (space-wizards#29969) * fix(jugs): Make max and minimum transfer amounts make sense * fix name * Better * Implement bounds checks * large beaker too * More logical solution * Bleh * remove * Doesn't make sense yet WAS MISTAKEN AAAAAAAAAAAAAAD@ @! * Fix admin logs cache caching rounds forever if multiple game servers are ran on the same db (space-wizards#30687) * add(fland): Add a space cleaner dispenser to flands janitoral department (space-wizards#30695) * add(reach): Add a space cleaner dispenser to flands janitoral department (space-wizards#30697) * add(emergency_omega): Add defib to medical treatment area (space-wizards#30693) * Make biofab distinct from biogen (space-wizards#30696) * Make biofab distinct from biogen * biocube fabricator * Add comment into jetpack system, to prevent future grid jetpack PRs (space-wizards#30682) Update SharedJetpackSystem.cs * Automatic changelog update * Vox nukies and ninjafix (space-wizards#29783) * Nukie species gear * antagselectionsystem autointernals * nukie vox * skrek * Remove duplicate code * skrek * EVA tank loadouts, vox ninja update * fix prototype duplication * skrek * fix summary * fixed empty startinggear error * enable vox ninjas * Comments * removed comment because startinggearprototype should not be used on antagselection aaaanyway * squish that if * Update Content.Shared/Clothing/LoadoutSystem.cs --------- Co-authored-by: metalgearsloth <[email protected]> * better examine text for radiation collectors (space-wizards#30606) * better examine text for radiation collectors * this? * penis * Automatic changelog update * Add whitelist to cryostorage (space-wizards#30574) * Automatic changelog update * Replace xform.WorldPosition with xformSystem method for Setting/Getting (space-wizards#30029) * GET WORLD POSITON, ROTATION * Missing parentheses * ui system depndency * the issue * Unused * Let the function do the transform --------- Co-authored-by: plykiya <[email protected]> * Vox head displacement map (space-wizards#30699) * head displacement for vox * fixe * Automatic changelog update * fix(emergency_meta): Lock the doors on evac shuttle (space-wizards#29255) * fix(emergency_meta): Lock the doors on evac shuttle * marathon update (space-wizards#30714) * marathon update * marathon update * packed update (space-wizards#30716) * train update (space-wizards#30721) * train update * train * Add mapping load acts (space-wizards#30722) Smug doesn't seem to have time to fix mapping state and I don't want to dump more time into it so. * Add more storage admin logs & fix some interaction validation (space-wizards#30725) * bagel update (space-wizards#30727) * bagel update * remove invalid * Fix Mind Transfer and Role Assignment Logic for Antagonists (space-wizards#30711) * AntagSelectionSystemFix * readded the stuff that shouldn've been deleted in the first place * re-arrange * undo indentation --------- Co-authored-by: Nemanja <[email protected]> * Vox Medical Mask sprite fix (space-wizards#30702) vox medical mask * Automatic changelog update * fix(FieldGenerators): Add missing connection check (space-wizards#30468) . * Replace IClickAlert with events (space-wizards#30728) * Replace IAlertClick with events * whoop * eek! * Space Dragons can't be flashed (space-wizards#30658) * added flash immunity component to Space Dragon * Changed use of component to use of whitelist * Automatic changelog update * bagel update (space-wizards#30730) big gas miners * martathon update (space-wizards#30731) martathon * Dragdrop fold rollerbed (space-wizards#30002) * Deploy foldable * Add NetworkedComponent and access to the component * Add handled to afterinteract * Use drop target location instead of setcoordinates * Put back in hand after failed deploy This prevents dropping the bed when clicking while inside a locker. * Created BaseDeployFoldable for folding chairs, body bags, and rollerbeds * Add dragdrop to fold rollerbed to hand * Automatic changelog update * Updated remaining ghostroles for species loadouts (space-wizards#29746) * LoadoutSystem change, deathsquad species loadout * survival gear loadouts for disaster victims * skrek * centcom * syndicate agent * cburn * ERT * syndicates * Is it ever gonna be enough? * Take what you can * Move startingGearEquippedEvent after Loadouts are spawned * skreee * even more formatting * Unbreak auto internals activation * undo AddAllRoleLoadouts change * syndicate reinforcement survival loadouts * re-enable vox ghostroles * Automatic changelog update * Rename mining walls as "mining walls" (space-wizards#30729) * fix * re-check * re-check vol.2 season battle pass episode * да иди ты нахуй уже * re-cheeeck * Fix warning cone rotation in inventory (space-wizards#30672) * butter is slippery (space-wizards#29772) * butter slippery * rerun tests * standardize * Automatic changelog update * Don't disable collision on dead mobs, fixes an issue with pulling (space-wizards#30532) Update MobStateSystem.Subscribers.cs * Add more advertisements (space-wizards#30653) * Strip drag drop test (space-wizards#30754) * Add test for drag drop to open strip menu * Make screencoords change based on deadzone * Add verbose (client predicted!) examine text to Gas Miners (space-wizards#30480) * add verbose examine text to gas miners so their behaviour can be understood * no need for these to be properties * use an enum instead of two booleans for the miner state * require the gas miner to be anchored in order to not be disabled * xmldoc * pr feedback * file-scope namespace * it's to late to hide my transgressions in a rebase * turns out the normal examine distance is totally fine for this * Automatic changelog update * Update submodule to 229.1.2 (space-wizards#30764) Tests should work decently again * Remove obsolete occurrences of IComponent.Owner being assigned just before AddComponent (space-wizards#30724) * Improved Spanish accent (space-wizards#30551) * Spanish and French comment * Added the interrobang * Make spanish accent use sting builder * Automatic changelog update * remove GenericAntag completely (space-wizards#28218) Co-authored-by: deltanedas <@deltanedas:kde.org> Co-authored-by: metalgearsloth <[email protected]> * Add EntityWorldTargetAction (space-wizards#29819) * Add EntityWorldTargetAction initial implementation * Update obsolete methods * Partially working EntityWorldTargetAction * Fix entity selection * Move and clean up AfterInteract * Fix building new walls * Readd no entity or coordinates error * Consolidate action validation code * Add summaries to component --------- Co-authored-by: Ed <[email protected]> * ai stays seated and pulled while cuffed. (space-wizards#30397) * ai stays seated while cuffed. * Do the thing I thought was dumb.... whatever. * less than * more consistent CentComm naming (space-wizards#29217) * first-commit * second commit * i think i get git kinda maybe * all of resources i think * last easy changes * oops * Update Resources/Prototypes/Entities/Clothing/Head/hoods.yml --------- Co-authored-by: stroopwafel <[email protected]> Co-authored-by: Plykiya <[email protected]> Co-authored-by: metalgearsloth <[email protected]> * Buff EMP implant and grenade range (space-wizards#30660) Co-authored-by: plykiya <[email protected]> * Automatic changelog update * Teleport and delete buttons in objects tab. (space-wizards#28914) * Тыкнул и нету ЦК * review --------- Co-authored-by: metalgearsloth <[email protected]> * Add BreakOnDropItem, update do afters, remove unnecessary declarations (space-wizards#30361) * Add BreakOnDropItem, update do afters, remove unnecessary declarations * bola * Changed my mind about the nuke * gennies too * Make the comments more clear. * Sorry for the trailing commas * Revert "Sorry for the trailing commas" This reverts commit e60fd9a. --------- Co-authored-by: plykiya <[email protected]> * Automatic changelog update * Thief beacons (try 2) (space-wizards#29997) content * Automatic changelog update * Fix for issue 30781 (space-wizards#30788) Fixed typos in name and description of syndicate recruit jumpsuit. * Remove suspect figurine line (space-wizards#30795) * train update (space-wizards#30797) train fix * Add RD labcoat in RD's dresser (space-wizards#30671) * Automatic changelog update * Better DNA forensics & ReagentData (space-wizards#26699) * Added the ability for blood to track DNA using ReagentData; Forensic Scanner now accounts for solution DNA, non-DNA holders have "Unknown DNA" * Removes touch DNA for puddles, adds DNA to vomit * DNA now leaves traces in containers and those marked without don't show DNA on scan (except for puddles), gibbed parts have DNA * Fix stupid metamorphic glass bug grrr * Removed SpillableComponent since DnaSubstanceTraceComponent is used instead * Removes data field from maps, adds DNA tracking for some missed items * Give default value, fix missing values. * Fixes recipe bug * Review changes * Make the Data list into a nullable type * Revert map changes * Move gibbed unknown DNA to forensicssystem * Automatic changelog update * Scrap (space-wizards#30762) * jnk sprites * scrap pt 2 * metal inhands * hell yeah brudda * Update meta.json * Update scrap.yml --------- Co-authored-by: Flareguy <[email protected]> * Add butter slices (space-wizards#30789) * Automatic changelog update * full sticky prediction (space-wizards#30230) * move all sticky stuff to shared and cleanup/grammar fix * update imports and ref --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Secret stash refractor (space-wizards#29396) * First commit * Will do this in another PR! * maybe? * Moved stuff to ToolOpenableSystem because its smarter and cooler * offgrid mob friction (space-wizards#29383) * offgrid mob friction * save the world... * Automatic changelog update * remove UntrackedMapBoundUserInterface (space-wizards#30752) * Add random seed options to tests (space-wizards#30735) * Add random seed options to tests * Ensure profile randomization * Create Generic DamageOnInteract/Attacked Comps/Systems (space-wizards#30244) * Everything but the submodule * stuff I forgot * heat * missed lights * behonky * LocId * I guess it was a skill issue? * predicted audio * It works with lights now * Borg equality * Gorilla gauntlet grants protection from anomaly returned damage when attacking it * woops, there we go * NONE * Use DamageModifierSets, remove Behonker damage * Reviews dealt with --------- Co-authored-by: plykiya <[email protected]> * Implement a playerpanel (space-wizards#30238) * Basic structure for the player panel ui * Ensure basic functionality Player panel now receives and displays basic info * Make whitelistcommands accept user ids * Make PlayerPanel use GUIDs where possible * Add functionality to most playerpanel buttons * Implement remaining playerpanel features * Localize everything * Finish up * Put command arguments in quotes I am not sure if it's even possible to have something like a space in them considering they are guids and usernames but sure why not * Make playerpanel a verb * Add Logs button to player panel * Change Notesbutton text and make whitelistbutton a confirmtion button * Add freeze button that does not mute the player * Add sharedconnections counter to playerpanel * Make the playetime format clearer * Allow for copying of the a player's username * Do minor cleanup * Rearrange buttons * Fix unfreeze button not updating * Fix wrong localisation text * "Fix" the same role ban counting multiple times The way rolebans are stored is horrible. As such if you ban someone from a departmenrt or something role bans are individually placed for every role. The only way I found to distinguish them is the bantime. This is horrible but I do not want to rewrite how all the bans are stored right now. * Add Delete and Rejuvenate buttons to player panel By popular demand * Marginally improve ui * Add logs * review update * Fix verb * Fix double notes --------- Co-authored-by: metalgearsloth <[email protected]> * Automatic changelog update * require the warden to notify admins on disconnect (space-wizards#30745) * Automatic changelog update * Fix decal megadiffs (space-wizards#30732) Just preserves the uids and doesn't care about trying to re-map the decals lower. We have a uint to work with anyway. * Fix Panic bunker and Baby Jail being up to 14hrs incorrect. (space-wizards#30581) Fix a potential bypass for Panic bunker and baby Jail * Automatic changelog update * Add replacement words to Russian accent (space-wizards#30554) * add(FaxComponent): Allows for setting defaults in the component. (space-wizards#30484) * add(FaxComponent): Allows for setting defaults in the component. This wires up the Fax component to allow the default paper and office paper to be set. The defaults are what they were before, and it's an optional option. Now Fax machines can be set to print different paper when using Print File or other cases where the default paper style is used. * Requested change to EntProtoId. * Fix build failure. * Add minimum required trigger speed to mouse traps (space-wizards#30593) Co-authored-by: plykiya <[email protected]> * Create In-Guidebook Errors (space-wizards#28942) * Create in-guidebook errors * Localize client-facing parser error * Uncomment line * Missed another localization string * Add tooltips to the agent ID job icons and improve status icon prototypes (space-wizards#28575) * add tooltips to agentid job icons * forgot to stage this * make StatusIconPrototype abstract * minor visual improvements * cleanup * use currentculture to sort job names * review * Automatic changelog update * UI to edit silicon laws from admin verb (space-wizards#28483) * UI to edit silicon laws from admin verb (peak shitcode) * Improve UI * Use Moderator admin flag * Reviews * Automatic changelog update * Head bandana ingestion blocking fix (space-wizards#28910) * Automatic changelog update * tweak(HealthAnalyzer): Stop showing poup when used on self or when cancelled (by twitter) (space-wizards#30467) * . * Log enrichment: Explosion damage to players (space-wizards#29762) * Log enrichment: Explosion damage to players * Update Content.Server/Explosion/EntitySystems/ExplosionSystem.Processing.cs Co-authored-by: Chief-Engineer <[email protected]> * Revert to total damage variant only, currently serialised as string. * Make this its own log type. --------- Co-authored-by: Chief-Engineer <[email protected]> * Add admin logs to Rehydration comp. (space-wizards#30597) * Automatic changelog update * Fix(CuffableSystem): Check if cuffs can be transferred(dropped) (space-wizards#30465) * ugh * Revert "ugh" This reverts commit 8b5b0e2. * Revert "Automatic changelog update" This reverts commit 4f8b634. * Revert "Revert "Automatic changelog update"" This reverts commit 9fc2a33. * Revert "Revert "Revert "Automatic changelog update""" This reverts commit 1ae733b. * Revert "Revert "Automatic changelog update"" This reverts commit 9fc2a33. * Revert "" This reverts commit 1cc0953. * Revert "" This reverts commit edca368. * Revert "Revert "ugh"" This reverts commit 3ac15df. * Revert "Revert "Revert "ugh""" This reverts commit b952a45. * Revert "Revert "Revert "Revert "ugh"""" This reverts commit ff1a151. * Revert "ugh" This reverts commit 8b5b0e2. * Update SharedCuffableSystem.cs * Make hotplate and grill anchorable on table part 2 (space-wizards#29454) * Make hotplate and grill anchorable on table part 2 * Update hotplate.yml * add ghost role raffle to sentient artifact (space-wizards#30746) arti raffle * setgamepreset command rework (space-wizards#30756) * gameticker.gamepreset namespace * setgamepreset now has a finite duration * comments, cleanup * Make clickable 1% nicer (space-wizards#29706) * Make vox roundstart I believe all the issues are fixed. * Click detection bandaid * Make clickable 1% nicer Still bad. Still doesn't handle multi-viewports well. * Automatic changelog update * New decals for mapping (space-wizards#30374) * new decals * license * re-check * Automatic changelog update * Add access to gun components (space-wizards#30688) * Add access to gun components Found from an rmc14 PR. * Admin verbs proving why access needs to exist * Someone is probably going to post this pr to le reddit and complain about self-merges. * Revert "setgamepreset command rework" (space-wizards#30807) Revert "setgamepreset command rework (space-wizards#30756)" This reverts commit de86fdb. * Improve Criminal Records Computer usability (space-wizards#30292) * Avoid destroying and recreating record list on every update message * Add early-out on nullptr input * Remove sussy null suppress --------- Co-authored-by: Eoin Mcloughlin <[email protected]> Co-authored-by: metalgearsloth <[email protected]> * improve job special (space-wizards#30753) * cleanup of AddComponentSpecial * add RemoveComponentSpecial * require --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Resprite the equipped gas canister suit slots (space-wizards#30809) * add * red and generic * add meta * Automatic changelog update * Fix for stripping doafters (space-wizards#30821) Apparently I need to check if they're holding an item Co-authored-by: plykiya <[email protected]> * [Sprites/Fix] In hand for BlueSpace beaker & CMO's equipped cloak (space-wizards#28719) * [Fix] CMO's equipped cloak * [Fix] CMO's equipped cloak * [Sprites] In hands for bluespace beaker * [Sprites] In hands for bluespace beaker * [Sprites] In hands for bluespace beaker * [Sprites] In hands for bluespace beaker * Add arm64 support to packager for windows and osx (space-wizards#29723) Wanted to package a server for the funny on my macbook and noticed it was not working cause of this... now it will workie :3 * Buckling an entity requires a do-after (space-wizards#29621) * Buckling an entity requires a do-after * Works but feels like bad code? * Cleanup --------- Co-authored-by: plykiya <[email protected]> * Automatic changelog update * Crowbar variants (space-wizards#28988) * add * comma * sprites * yaml-ify * add s * lathe and engi belt * yes * fix maybe * progress * nearly there * fix * fix yaml linter having a stroke * Automatic changelog update * Crowbars fix (space-wizards#30828) * Crowbars fix * oops * Network WallMountComponent (space-wizards#30837) * Revert "Make hotplate and grill anchorable on table part 2" (space-wizards#30830) Revert "Make hotplate and grill anchorable on table part 2 (space-wizards#29454)" This reverts commit 268cab9. * Automatic changelog update * Entity Tables (EntitySpawnEntry replacement) (space-wizards#30579) * Entity table code * entity table examples * fix dat shit * access * tests tests tests * sloth review * Automatic changelog update * Changed chemistry airlock color (space-wizards#30666) * chem * re-check * re-check. again * checks just die. last try * re-check :blessrng: * Automatic changelog update * Bent pipes deal 8 thrown damage (space-wizards#30634) 8 pipe throw damage * Automatic changelog update * [S] hopefully prevents a repeat of 4 am on 8/10/2024 in the #server-leviathan-use channel (space-wizards#30851) cant test this because the documentation sucks ass but fuck it we ball * Change siren.ogg to gamma.ogg (space-wizards#30836) * remove TerminatorRoleComponent (space-wizards#30733) * Add Rat Kings wideswinging (space-wizards#30808) Update regalrat.yml * Automatic changelog update * Added suitskirt for psychologist (space-wizards#30709) * Added jumpskirt * added locale * Added spaces in code * Updated the meta * Automatic changelog update * ERT Chaplain Loadout fixer (space-wizards#30855) Chaplain fixy * Automatic changelog update * Infer type for EntSelector (space-wizards#30856) Infer type for EntSelector.cs * Partially revert light tube sprites (space-wizards#29091) * add * reduce contrast * Automatic changelog update * Cursed Mask (space-wizards#29659) * Cursed Mask * extra expressions * block ingestion * mind returning * okay fix the removal shit * Fix some locales (space-wizards#30860) * Fix some locales * forgor * space-wizards#30851 followup - murderficates links (space-wizards#30863) kneecaps links while we're at it * Remove meta voiceline from the passenger figure (space-wizards#30868) Update figurines.ftl * Standartize clothing recipes (space-wizards#29315) * Automatic changelog update * Reach tweaks reattempt 2 (space-wizards#30782) * uhhh fix stuff maybe * - added a fax machine - made botany slightly bigger to accommodate a nutrimax vending machine - added air alarms, scrubbers and a waste pipe network * tweak(snowy_labs): Remove non-valid holoparasite (space-wizards#30875) * Custom burgers - FoodSequence system (space-wizards#30755) * setup foodsequence * name generation and max layers limit * move to nutrition * move code to serverside * move to appearance data * marked fields as required * Update foodsequence.yml * b * burgeers! * Update produce.yml * Update meat.yml * Update burger.yml * fix duplicate naming * Update Resources/Locale/en-US/nutrition/components/food-sequence.ftl Co-authored-by: Hrosts <[email protected]> * merge flavor profiles * make food trash List<> * merge trash * Update FoodComponent.cs * Update FoodComponent.cs * organs and cannabis support --------- Co-authored-by: Hrosts <[email protected]> * Automatic changelog update * chore(bagel): Remove EntityStorageComponent (space-wizards#30881) * chore(meta): Remove EntityStorageComponent (space-wizards#30883) * chore(omega): Remove EntityStorageComponent (space-wizards#30879) * chore(marathon): Remove EntityStorageComponent (space-wizards#30877) * chore(atlas): Remove EntityStorageComponent (space-wizards#30876) * tweak(oasis): Lower the engineering borg spawn (space-wizards#30874) * add(meta): Add missing airvent to airlock (space-wizards#30871) * Updated Core boxing ring beacon (space-wizards#30800) Updated boxing ring beacon to be correctly labeled * tweak(Shuttle_honki): Replace clown spiders with honkbots (space-wizards#30617) * Automatic changelog update * Vox Minor Clothing Update 2: Electric Boogaloo (space-wizards#30838) * more vox masks n stuff * cluwne * fix * merc gas mask * bunny tail height fix * Automatic changelog update * Remove lube and glue grenades from roundstart loadouts. * Revert "Added Medical Patches (space-wizards#452)" This reverts commit e40a34c. * Revert "Revert "Added Medical Patches (space-wizards#452)"" This reverts commit c4aab23. * Revert "Revert "Revert "Added Medical Patches (space-wizards#452)""" This reverts commit ac172da. * Revert "Set Outfit as an admin works again!!!!!! (space-wizards#392)" This reverts commit 87700a9. * Please * Finally fixed? --------- Co-authored-by: Repo <[email protected]> Co-authored-by: PJBot <[email protected]> Co-authored-by: JustCone <[email protected]> Co-authored-by: Alzore <[email protected]> Co-authored-by: IProduceWidgets <[email protected]> Co-authored-by: OrangeMoronage9622 <[email protected]> Co-authored-by: to4no_fix <[email protected]> Co-authored-by: RiceMar1244 <[email protected]> Co-authored-by: EmoGarbage404 <[email protected]> Co-authored-by: lzk <[email protected]> Co-authored-by: slarticodefast <[email protected]> Co-authored-by: Joel Zimmerman <[email protected]> Co-authored-by: Brandon Hu <[email protected]> Co-authored-by: voidnull000 <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DrSmugleaf <[email protected]> Co-authored-by: DrSmugleaf <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> Co-authored-by: Ian <[email protected]> Co-authored-by: Mervill <[email protected]> Co-authored-by: Ubaser <[email protected]> Co-authored-by: Plykiya <[email protected]> Co-authored-by: plykiya <[email protected]> Co-authored-by: beck-thompson <[email protected]> Co-authored-by: Killerqu00 <[email protected]> Co-authored-by: Cojoke <[email protected]> Co-authored-by: Simon <[email protected]> Co-authored-by: Ed <[email protected]> Co-authored-by: Errant <[email protected]> Co-authored-by: foboscheshir <[email protected]> Co-authored-by: SlamBamActionman <[email protected]> Co-authored-by: Nemanja <[email protected]> Co-authored-by: Flareguy <[email protected]> Co-authored-by: Emisse <[email protected]> Co-authored-by: Leon Friedrich <[email protected]> Co-authored-by: NakataRin <[email protected]> Co-authored-by: Lye <[email protected]> Co-authored-by: ShadowCommander <[email protected]> Co-authored-by: Ko4ergaPunk <[email protected]> Co-authored-by: Mr. 27 <[email protected]> Co-authored-by: TakoDragon <[email protected]> Co-authored-by: deltanedas <[email protected]> Co-authored-by: strO0pwafel <[email protected]> Co-authored-by: stroopwafel <[email protected]> Co-authored-by: Vigers Ray <[email protected]> Co-authored-by: saintmuntzer <[email protected]> Co-authored-by: dffdff2423 <[email protected]> Co-authored-by: themias <[email protected]> Co-authored-by: nikthechampiongr <[email protected]> Co-authored-by: Psychpsyo <[email protected]> Co-authored-by: CaasGit <[email protected]> Co-authored-by: Thomas <[email protected]> Co-authored-by: Stalen <[email protected]> Co-authored-by: TsjipTsjip <[email protected]> Co-authored-by: Chief-Engineer <[email protected]> Co-authored-by: Ilya246 <[email protected]> Co-authored-by: eoineoineoin <[email protected]> Co-authored-by: Eoin Mcloughlin <[email protected]> Co-authored-by: MureixloI <[email protected]> Co-authored-by: Vasilis <[email protected]> Co-authored-by: deathride58 <[email protected]> Co-authored-by: Unkn0wn_Gh0st <[email protected]> Co-authored-by: shamp <[email protected]> Co-authored-by: MerrytheManokit <[email protected]> Co-authored-by: Kukutis96513 <[email protected]> Co-authored-by: Hrosts <[email protected]> Co-authored-by: Preston Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Remove IClickAlert and just replaces it with events that get raised.
This also adds prediction support to the alerts that have code in shared (pulling and cuffing)
Technical details
Allows for way simpler code that is more flexible since you aren't locked into the shitty interface method and can actually use multiple event subs and proper entitySystem methods.
doing events also means that you can implement it in shared or on the server, vs before where it had to be on the server only.
Media
Requirements
Changelog
no cl no fun