Only auto-enable internals when necessary #28248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this account for toxic gasses in the air? I haven't read the code but I could imagine this causing issues if, say, a Vox spawned but didn't turn on internals due to the fact that there's Nitrogen in the airmix, ignoring the oxygen. |
Not yet, but I can add that |
|
Should now check for toxic gasses as well, though GetSaturation is still pretty janky |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the internals
StartingGearEquippedEventlogic so that it only enables internals when required, and only if the linked tank actually allows the entity to survive. Should hopefully stop the random test failures.The most dubious code is in
RespiratorSystem.GetSaturation(), as that bodges some of the reagent effect condition checks, which generally require a fullReagentEffectArgsstruct.