Reduced Warning Count By 130 For Full Rebuilds #26518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing count by approximately 50
|
I'm commander panda and this is my favourite pr in the codebase |
ShadowCommander
requested changes
Mar 28, 2024
Comment on lines
-51
to
-57
| /// <summary> | ||
| /// While processing an explosion, the "progress" is sent to clients, so that the explosion fireball effect | ||
| /// syncs up with the damage. When the tile iteration increments, an update needs to be sent to clients. | ||
| /// This integer keeps track of the last value sent to clients. | ||
| /// </summary> | ||
| private int _previousTileIteration; | ||
|
|
There was a problem hiding this comment.
@ElectroJr Any comments on this?
|
If you've finished a review comment, you can click the |
ShadowCommander
approved these changes
Mar 29, 2024
DEATHB4DEFEAT
added a commit
to Simple-Station/Einstein-Engines
that referenced
this pull request
Jul 12, 2024
Uses the following Cherry-Picks: space-wizards/space-station-14#26994 space-wizards/space-station-14#26518 space-wizards/space-station-14#26279 space-wizards/space-station-14#24946 space-wizards/space-station-14#27188 Requires: #535 #534 --------- Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Leon Friedrich <[email protected]> Co-authored-by: Jake Huxell <[email protected]> Co-authored-by: Tayrtahn <[email protected]> Co-authored-by: 0x6273 <[email protected]> Co-authored-by: DEATHB4DEFEAT <[email protected]>
Vaaankas
pushed a commit
to machination-of-ruin/errorgate
that referenced
this pull request
Sep 3, 2024
Uses the following Cherry-Picks: space-wizards/space-station-14#26994 space-wizards/space-station-14#26518 space-wizards/space-station-14#26279 space-wizards/space-station-14#24946 space-wizards/space-station-14#27188 Requires: Simple-Station/Einstein-Engines#535 Simple-Station/Einstein-Engines#534 --------- Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Leon Friedrich <[email protected]> Co-authored-by: Jake Huxell <[email protected]> Co-authored-by: Tayrtahn <[email protected]> Co-authored-by: 0x6273 <[email protected]> Co-authored-by: DEATHB4DEFEAT <[email protected]> (cherry picked from commit 30fa120)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Non functional code changes to reduce overall warning counts, specifically across the more commonly compiled game build paths.
Why / Balance
At the moment we have well over a thousand warnings for full rebuilds, and in the hundreds for most other incremental ones. This makes them pretty much noise and useless. Reducing the warning count is generally well correlated with fixing problematic chunks of code, as well as making them useful again!
Technical details
The warnings I tackled in this PR are specifically unused variables, dead code paths and the deprecated entity coordinate extension functions. These are all fixable without any structural changes so were the easiest first warnings to remove. You should see the changes are for the most part removing dead code. The other modifications are calling the coordinate extension functions with entity instead of component (as well as maybe two cases of bad variable names). Let know if there's any concerns!
Media
Breaking changes
Changelog
🆑 Jake Huxell