Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better deconversion #23315

Merged
merged 8 commits into from
Jan 14, 2024
Merged

Conversation

deltanedas
Copy link
Contributor

@deltanedas deltanedas commented Jan 1, 2024

About the PR

when all headrevs die:

  • all revs get a window explaining they got deconverted
  • role is now removed when deconverted

Why / Balance

Technical details

first xaml eui real??

Media

the window
14:52:43

no longer valid
07:46:23

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

no

Changelog
🆑

  • tweak: Revolutionaries that are deconverted by headrevs dying get a window shown explaining that they are no longer revs, to help with tunnel vision.

@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Jan 1, 2024
@Rainbeon
Copy link
Contributor

Rainbeon commented Jan 1, 2024

Is "You forget everything that happened since being converted" even true though? It does not seem to be part of the rules nor MRP's New Life Rule. It is also not included in the "Rules Clarifications" section, so this seems to be untrue overall? Seems like a weird inclusion.

@deltanedas
Copy link
Contributor Author

deltanedas commented Jan 1, 2024

its not a rule but:

  1. makes it clearer that revs arent liable for anything they did :trollface: which is already how its done in practice
  2. you shouldnt really act on information while you are hypnotised
  3. revs cant testify to what a headrev did while they are converted

this is based on gameplay from mrp idk how lrp shitters handle it

@deltanedas
Copy link
Contributor Author

could remove the amnesia bit if admins think its best

@Rainbeon
Copy link
Contributor

Rainbeon commented Jan 1, 2024

If we want a rule change on how Deconversion memory works that should come separately from this no? That's an over-arching rule change and the only way to learn about it is through this specific end-game prompt (not even on mind-shielding deconversion, which is where this seems more important to mention...).

revs cant testify to what a headrev did while they are converted

This is a very large change in the dynamics of a Revs round than what seems relevant to the scope of this PR (notification of deconversion), and seems far more important to mention during a mind-shielding than in the aftermath of HRs dying anyway, as all it really does when being mentioned here is remove any RP relating to the consequences of your actions/coping and such, rather than disallow Revs from testifying against an HR.

I'd rather see the amnesia mention removed and memory retention decided upon as an actual rule change from admins first, given how much it changes.

@GreyMario
Copy link
Contributor

Consensus is that Revolutionary conversion is brainwashing, not hypnosis. You are fully aware and have memory.

@JerryImMouse
Copy link
Contributor

Is it a good idea to make UI with C#? I think it can be done with XAML easier and will make the code more readable

@deltanedas
Copy link
Contributor Author

Is it a good idea to make UI with C#? I think it can be done with XAML easier and will make the code more readable

i have no idea i just copy pasted it

@LordCarve
Copy link
Contributor

LordCarve commented Jan 1, 2024

At a strong risk of being called nitpicky, the last line You are no longer an antagonist, so be nice. isn't always true if someone was a double antagonist.

That being said, reminding people to act according to their objectives is a definite must-have, so this probably just needs a rewording:

  • Maybe pose this as a speculative/conditional sentence? "If you are no longer an antagonist, be nice."
  • Be more specific? "You are no longer a revolutionary, so be nice."

I like the latter more.

Alternatives include conditional check if player is still an antagonist, but that is probably overdoing it.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 3, 2024
Copy link
Contributor

github-actions bot commented Jan 3, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@metalgearsloth metalgearsloth added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Jan 4, 2024
@ps3moira
Copy link
Contributor

thank you 🙏 unconverted revs gibbing clown will now know they're not rev and gib clown in peace.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 13, 2024
@github-actions github-actions bot added the Changes: UI Changes: Might require knowledge of UI design or code. label Jan 13, 2024
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Jan 13, 2024
@metalgearsloth metalgearsloth enabled auto-merge (squash) January 14, 2024 03:20
@metalgearsloth metalgearsloth merged commit a558b11 into space-wizards:master Jan 14, 2024
11 checks passed
@deltanedas deltanedas deleted the deconvert-ops branch January 14, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: UI Changes: Might require knowledge of UI design or code. S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revs dont lose briefing when headrev dies
7 participants