Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "Vanilla JS" highlight from README #656

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

tamasflamich
Copy link
Contributor

@tamasflamich tamasflamich commented Oct 17, 2022

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

The documentation states that the codebase is written in "readable vanilla JavaScript".

New behaviour

It doesn't seem to be the case anymore, therefore, it was removed.

Other information (e.g. related issues)

@darrachequesne darrachequesne merged commit 1b71a6f into socketio:main Nov 18, 2022
@darrachequesne
Copy link
Member

@tamasflamich good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants