Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL for a bluesky account bridged to the fediverse #1529

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frzysk
Copy link

@frzysk frzysk commented Nov 20, 2024

hi hello

This is mostly a proposal made as a pull request because I don't know the source code of bridgy-fed or the protocols much, and because I couldn't make a Cloud SDK account to modify and run the tests sowwy. So there's probably things to change.

I've seen that for the message @[email protected] is already bridged into the fediverse. (that I received on fedi about a bluesky profile), the user wasn't a link. That made me sad so I tried to modify that.

I added ActivityPub.bridged_web_url_for() that works for any BlueSky account and returns a url like https://bsky.brid.gy/r/https://bsky.app/profile/blueskyuser.bsky.social. That's the type of url I get if I post something mentioning a bsky.brid.gy account from the fediverse.

The code I added is way smaller than this description

thanks :))

Returns an url from https://bsky.drid.gy/r/* for any bridged bluesky account.
@Tamschi
Copy link
Collaborator

Tamschi commented Nov 21, 2024

It's a bit tricky because of how Mastodon handles user mentions that actually open in the UI. See #887 (comment) for technical details.

In theory it's feasible though. Since Bridgy Fed would be the target 'instance' of the mention here, it could filter out these messages somewhat easily in cases where they would have any effect when received by the bridge. It's probably somewhat involved though.

@Tamschi Tamschi added the feature Features and feature requests that are specific to Bridgy Fed, not fully described by the protocols. label Nov 21, 2024
@snarfed
Copy link
Owner

snarfed commented Nov 21, 2024

Thanks for the contribution @frzysk!

@Tamschi is right, the goal here is to link to the bridged account, not the original account, so we'd want to link these addresses so that they open the bridged fediverse profile in the local instance, a la #887.

That's proved pretty difficult so far. We have a lead on how to do it though, described at the bottom of that issue. Feel free to try!

(Btw you shouldn't need a Google account, or any other account, to download and install the Google Cloud SDK so that you can run tests.)

@frzysk
Copy link
Author

frzysk commented Nov 29, 2024

Thanks for the answers! I'll see if I have the time/energy to, someday

@Tamschi
Copy link
Collaborator

Tamschi commented Nov 30, 2024

I'll convert this into a draft for now, just so it's easy for us to see that the PR is a work in progress.

Feel free to convert it back once the PR is ready for review!

@Tamschi Tamschi marked this pull request as draft November 30, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features and feature requests that are specific to Bridgy Fed, not fully described by the protocols.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants