Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add browser and git #3

Closed
mhmh55516 opened this issue May 21, 2020 · 7 comments
Closed

add browser and git #3

mhmh55516 opened this issue May 21, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@mhmh55516
Copy link

Hi can you add firefox browser ?!
Thank you

@mhmh55516
Copy link
Author

and add chromium-browser please

@mhmh55516
Copy link
Author

and add git

@scottyhardy
Copy link
Owner

Hi @mhmh55516

All these requests are simple enough and I think others would find value in having a browser and git - although I’ll add them to the docker-remote-desktop base image. I’d prefer just a single browser to keep the size down though - I’m thinking Chromium may be better due to Flash support without needing a separate flash add-on. Let me have a play and I’ll make a decision.

@scottyhardy scottyhardy self-assigned this May 21, 2020
@scottyhardy scottyhardy changed the title add firefox add bowser and git May 21, 2020
@scottyhardy scottyhardy changed the title add bowser and git add browser and git May 21, 2020
@scottyhardy scottyhardy transferred this issue from scottyhardy/docker-wine May 21, 2020
@scottyhardy scottyhardy added the enhancement New feature or request label May 21, 2020
@scottyhardy
Copy link
Owner

I ended up going with Firefox as it's the most common browser for Linux and Chromium is provided by snapd package manager which I couldn't get to work. I'm not including Flash plugin due to it nearing end of support.

I'll need to update the docker-wine script to include --shm-size="1g" to the docker run command, otherwise Firefox tabs continually keep crashing. I'll get that updated once I've pushed out the updated images.

@mhmh55516
Copy link
Author

you can run Chromium with this command "chromium --no-sandbox"

@scottyhardy
Copy link
Owner

The issue was when trying to install chromium during a build it kept failing to contact the snap server. I originally used apt-get install and also tried installing snapd and using snap install but both methods failed so I stopped there.

@scottyhardy
Copy link
Owner

Hi @mhmh55516

This issue's been resolved now and I've tested to ensure the downstream docker-wine image includes Firefox and git. Thanks for the feedback and suggestions 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants