Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode, Alert Dialog width issue, Default text is changed to dismiss from submit in status dialogs. #11

Closed
wants to merge 13 commits into from
Closed

Dark mode, Alert Dialog width issue, Default text is changed to dismiss from submit in status dialogs. #11

wants to merge 13 commits into from

Conversation

abusaeed2433
Copy link
Contributor

  1. Dark mode added
  2. Alert Dialog was taking full width while displaying. It is changed to 300dp like other dialog.
  3. Default text in status dialog is changed to Dismiss from submit.
  4. Buttons are added in MainActivity for previewing all the dialog.

@saadahmedscse saadahmedscse self-requested a review May 12, 2024 07:18
saadahmedscse
saadahmedscse requested changes Dec 31, 2024
View reviewed changes
Copy link
Owner

@saadahmedscse saadahmedscse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding light and dark mode colors is unnecessary and will not be merged. If you have any other ideas about developing this library or adding more features you can do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saadahmedscse saadahmedscse saadahmedscse requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abusaeed2433 @saadahmedscse