support SVGView and css file init from local file, made init methods more safety #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ade init methods more safety to not get crash if there is no SVG or CSS file
s2mr
reviewed
Jun 10, 2019
Sources/SVGLoader.swift
Outdated
| @@ -32,43 +32,78 @@ public final class SVGLoader { | |||
| } | |||
| """) | |||
| } | |||
|
|
|||
| public func buildHtml(svg: String) -> String { | |||
There was a problem hiding this comment.
I felt strange that this method is in a Style struct.
What do you think of moving this method to an SVG Loader member function?
There was a problem hiding this comment.
@kzumu I fixed it, could you check it?
|
Thanks for your contributing! |
|
Yep, at first I wanted to keep it as SVG Loader method, but html should be built in init method, so we can't call this method in init, because at that moment self is not defined as well. If you try to do it you'll see error. |
|
@kzumu I moved html building from Style to separated struct, please check |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support SVGView and css file init from local file, not only bundle, made init methods more safety to not get crash if there is no SVG or CSS file