Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always enable flat net construction #1002

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Always enable flat net construction #1002

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fa90463
Always enable flat net construction
albertz Mar 17, 2022
19aa9b3
test_flat_net_construction, no flat_net_construction option
albertz Mar 17, 2022
12102ba
_DelayedConstructionException, nicer repr
albertz Mar 17, 2022
e3b567f
flat construction, small fix
albertz Mar 17, 2022
e372d3b
flat construction, refactor, cleanup
albertz Mar 17, 2022
5c4b1bc
flat construction, small fix
albertz Mar 17, 2022
fbde04d
flat construction, small fix
albertz Mar 17, 2022
b6f6c32
flat construction, cleanup
albertz Mar 17, 2022
0318dcb
flat construction, refactor, cleanup, fix
albertz Mar 17, 2022
b7e3e9b
flat construction, allow nested
albertz Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Always enable flat net construction 
Fix #992
  • Loading branch information
@albertz
albertz committed Mar 17, 2022
commit fa90463596fea1c311e350b07014718b42a1edfd
26 changes: 7 additions & 19 deletions returnn/tf/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,17 +786,6 @@ def get_layer(src_name):
self.used_data_keys.update(extra_net.used_data_keys)
return created_layers

def _flat_construction_enabled(self):
"""
:return: whether to use flat construction algorithm in :func:`construct_layer`.
Use this if you get stack overflow errors, such as:
``Fatal Python error: Cannot recover from stack overflow``
or
``RuntimeError: maximum recursion depth exceeded``.
:rtype: bool
"""
return self.get_config().bool("flat_net_construction", False)

def construct_layer(self, net_dict, name, get_layer=None, add_layer=None, check_existing=True):
"""
This triggers the construction of the layer `name` if it is not constructed yet.
Expand Down Expand Up @@ -918,14 +907,13 @@ def construct_layer(self, net_dict, name, get_layer=None, add_layer=None, check_
layer_name=full_name, network=self)
return sub_layer

if self._flat_construction_enabled():
delayed_exc = _DelayedConstructionException(
network=self, layer_name=name,
other_kwargs=dict(net_dict=net_dict, get_layer=get_layer, add_layer=add_layer, check_existing=check_existing))
if not self._construction_stack.in_flat_construct_count:
return self._construction_stack.flat_construct(delayed_exc)
if self._construction_stack.layers:
raise delayed_exc
delayed_exc = _DelayedConstructionException(
network=self, layer_name=name,
other_kwargs=dict(net_dict=net_dict, get_layer=get_layer, add_layer=add_layer, check_existing=check_existing))
if not self._construction_stack.in_flat_construct_count:
return self._construction_stack.flat_construct(delayed_exc)
if self._construction_stack.layers:
raise delayed_exc

layer_desc = layer_desc.copy()
layer_desc.pop("class")
Expand Down