Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: convert add_braces to SyntaxFactory SyntaxEditor abstraction #18485

Merged
merged 6 commits into from
Nov 19, 2024
Merged

feat: convert add_braces to SyntaxFactory SyntaxEditor abstraction #18485

merged 6 commits into from
Nov 19, 2024

Conversation

davidkurilla
Copy link
Contributor

@davidkurilla davidkurilla commented Nov 6, 2024 •
edited
Loading

Changes:

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2024
@davidkurilla davidkurilla marked this pull request as ready for review November 12, 2024 23:58
@darichey
Copy link
Contributor

darichey commented Nov 13, 2024 •
edited
Loading

Looks like you just need to run cargo fmt. Also feel free to update the PR description now that you've got things working!

darichey
darichey approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@darichey darichey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@davidbarsky davidbarsky added this pull request to the merge queue Nov 19, 2024
Merged via the queue into rust-lang:master with commit c0bbbb3 Nov 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darichey darichey darichey approved these changes

@davidbarsky davidbarsky davidbarsky approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidkurilla @darichey @davidbarsky @rustbot