Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing i18n keys. #3208

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Fix missing i18n keys. #3208

merged 2 commits into from
Sep 12, 2022

Conversation

simi
Copy link
Member

@simi simi commented Sep 10, 2022

@simi simi requested a review from jenshenny September 10, 2022 21:11
@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Merging #3208 (a31783a) into master (693b63b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3208   +/-   ##
=======================================
  Coverage   98.18%   98.19%           
=======================================
  Files         110      110           
  Lines        3314     3320    +6     
=======================================
+ Hits         3254     3260    +6     
  Misses         60       60
Impacted Files Coverage Δ
app/helpers/rubygems_helper.rb 100.00% <100.00%> (ø)
app/controllers/multifactor_auths_controller.rb 100.00% <0.00%> (ø)
...ollers/concerns/application_multifactor_methods.rb 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@simi simi marked this pull request as ready for review September 10, 2022 21:29
jenshenny
jenshenny approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@jenshenny jenshenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@simi simi merged commit 3cc8bb1 into master Sep 12, 2022
@simi simi deleted the test-locales branch September 12, 2022 15:21
@rubygems-org-shipit rubygems-org-shipit bot temporarily deployed to staging September 12, 2022 15:30 Inactive
@rubygems-org-shipit rubygems-org-shipit bot temporarily deployed to production September 13, 2022 15:34 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenshenny jenshenny jenshenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simi @jenshenny