Autoload shellwords when it's needed. #6734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0c2ea8 to
69287ac
Compare
69287ac to
e916ccb
Compare
|
@ioquatix I believe it should be mostly safe, but let me elaborate a bit to give elements to decide. Adding an autoload is in practice like defining the constant, except that you defer the file evaluation. So this would be as "safe" as issuing a On paper, this would conflict with code bases that define their own |
|
Thanks so much for your great clarification and assurances. |
|
@deivid-rodriguez @simi I think this is good to go. |
deivid-rodriguez
approved these changes
Jun 9, 2023
|
Thanks! |
deivid-rodriguez
added a commit
that referenced
this pull request
Jun 27, 2023
Autoload shellwords when it's needed. (cherry picked from commit 127a20d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #6568.
Some code paths weren't loading
shellwordsand I experienced some errors because of this. So, adding a top level autoload avoids this problem.@fxn is it safe to add an autoload like this? i.e. are we at risk of clobbering anything if another project decided to do the same?