Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new InternalAffairs/LocationExists cop to check for code that can be replaced with Node#loc? or Node#loc_is? #13581

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dvandersluis
Copy link
Member

rubocop/rubocop-ast#345 and rubocop/rubocop-ast#346 add new methods for simplifying node location lookups. This internal affairs cop applies those new methods.

# bad
node.loc.respond_to?(:begin) && node.loc.begin

# good
node.loc?(:begin)

# bad
node.loc.respond_to?(:begin) && node.loc.begin.is?('(')

# good
node.loc_is?(:begin, '(')

# bad
node.loc.respond_to?(:begin) && node.loc.begin.source == '('

# good
node.loc_is?(:begin, '(')

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@dvandersluis
Copy link
Member Author

This is a draft for now since the changes to rubocop-ast are not yet released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant