[Fix #13309] Fix false negative with Lint/UselessAssignment
when an useless assignment exists followed by a block
#13389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar example false negative situation pointed in issue #13309 :
The issue here is that
Lint/UselessAssignment
checks if assignments have been used, however, the assignments check it based on the assignment having been referenced or the variable being used in a block. So, the false negative occurs because of the first assignment being unused but having the variable captured in a block. One potential way of solving this is too track reassignments (a new assignment follows a not referenced assignment).Fixes #13309.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.