Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added getAggregatedEffectiveRPLStake to RocketNodeStaking #275

Open
wants to merge 1 commit into
base: v1.2
Choose a base branch
from
+48 −0
Open

Added getAggregatedEffectiveRPLStake to RocketNodeStaking #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions contracts/contract/node/RocketNodeStaking.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,4 +283,52 @@ contract RocketNodeStaking is RocketBase, RocketNodeStakingInterface {
emit RPLSlashed(_nodeAddress, rplSlashAmount, _ethSlashAmount, block.timestamp);
}

/// @notice Get the combined effective RPL stake for all nodes in the provided range.
/// @param _offset The offset into the node set to start
/// @param _limit The maximum number of nodes to iterate
function getAggregatedEffectiveRPLStake (uint256 _offset, uint256 _limit) override external view
returns (uint256 aggregatedStake) {
// Load contracts
RocketNetworkPricesInterface rocketNetworkPrices = RocketNetworkPricesInterface(getContractAddress("rocketNetworkPrices"));
RocketDAOProtocolSettingsNodeInterface rocketDAOProtocolSettingsNode = RocketDAOProtocolSettingsNodeInterface(getContractAddress("rocketDAOProtocolSettingsNode"));
AddressSetStorageInterface addressSetStorage = AddressSetStorageInterface(getContractAddress("addressSetStorage"));

// Get min and max
uint256 rplPrice = rocketNetworkPrices.getRPLPrice();
uint256 minimumStakePercent = rocketDAOProtocolSettingsNode.getMinimumPerMinipoolStake();
uint256 maximumStakePercent = rocketDAOProtocolSettingsNode.getMaximumPerMinipoolStake();

// Precompute node key
bytes32 nodeKey = keccak256(abi.encodePacked("nodes.index"));

// Iterate over the requested node range
uint256 totalNodes = addressSetStorage.getCount(keccak256(abi.encodePacked("nodes.index")));
uint256 max = _offset.add(_limit);
if (max > totalNodes || _limit == 0) { max = totalNodes; }
for (uint256 i = _offset; i < max; i++) {
// Get the node at index i
address _nodeAddress = addressSetStorage.getItem(nodeKey, i);

// Get node's current RPL stake
uint256 rplStake = getNodeRPLStake(_nodeAddress);

// Retrieve variables for calculations
uint256 matchedETH = getNodeETHMatched(_nodeAddress);
uint256 providedETH = getNodeETHProvided(_nodeAddress);
uint256 minimumStake = matchedETH.mul(minimumStakePercent).div(rplPrice);
uint256 maximumStake = providedETH.mul(maximumStakePercent).div(rplPrice);

if (rplStake > maximumStake) {
// RPL stake cannot exceed maximum
aggregatedStake += maximumStake;
}
else if (rplStake < minimumStake) {
// If RPL stake is lower than minimum, node has no effective stake
}
else {
aggregatedStake += rplStake
}
}
}

}